[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL 05/22] pr-manager: Fix invalid g_free() crash bug
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PULL 05/22] pr-manager: Fix invalid g_free() crash bug |
Date: |
Thu, 12 Sep 2019 15:45:47 +0200 |
From: Markus Armbruster <address@hidden>
pr_manager_worker() passes its @opaque argument to g_free(). Wrong;
it points to pr_manager_worker()'s automatic @data. Broken when
commit 2f3a7ab39be converted @data from heap- to stack-allocated. Fix
by deleting the g_free().
Fixes: 2f3a7ab39bec4ba8022dc4d42ea641165b004e3e
Cc: address@hidden
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
scsi/pr-manager.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/scsi/pr-manager.c b/scsi/pr-manager.c
index ee43663576..0c866e8698 100644
--- a/scsi/pr-manager.c
+++ b/scsi/pr-manager.c
@@ -39,7 +39,6 @@ static int pr_manager_worker(void *opaque)
int fd = data->fd;
int r;
- g_free(data);
trace_pr_manager_run(fd, hdr->cmdp[0], hdr->cmdp[1]);
/* The reference was taken in pr_manager_execute. */
--
2.20.1
- [Qemu-block] [PULL 00/22] Block layer patches, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 01/22] qcow2: Fix the calculation of the maximum L2 cache size, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 03/22] block/file-posix: Reduce xfsctl() use, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 02/22] job: drop job_drain, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 04/22] iotests: Test reverse sub-cluster qcow2 writes, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 05/22] pr-manager: Fix invalid g_free() crash bug,
Kevin Wolf <=
- [Qemu-block] [PULL 07/22] vpc: Return 0 from vpc_co_create() on success, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 06/22] file-posix: Fix has_write_zeroes after NO_FALLBACK, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 08/22] iotests: Add supported protocols to execute_test(), Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 10/22] iotests: Restrict nbd Python tests to nbd, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 09/22] iotests: Restrict file Python tests to file, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 11/22] iotests: Test blockdev-create for vpc, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 12/22] iotests: skip 232 when run tests as root, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 13/22] block/nfs: add support for nfs_umount, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 15/22] iotests: exclude killed processes from running under Valgrind, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 16/22] iotests: Add casenotrun report to bash tests, Kevin Wolf, 2019/09/12