[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v5 15/28] hw/block/pflash_cfi02: Do
From: |
Alistair Francis |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v5 15/28] hw/block/pflash_cfi02: Document the current CFI values |
Date: |
Fri, 28 Jun 2019 09:33:09 -0700 |
On Thu, Jun 27, 2019 at 1:53 PM Philippe Mathieu-Daudé
<address@hidden> wrote:
>
> Signed-off-by: Stephen Checkoway <address@hidden>
> Message-Id: <address@hidden>
> [PMD: Extracted from bigger patch]
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Alistair Francis <address@hidden>
Alistair
> ---
> hw/block/pflash_cfi02.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
> index 1a794fa83c..f1bac480f5 100644
> --- a/hw/block/pflash_cfi02.c
> +++ b/hw/block/pflash_cfi02.c
> @@ -550,6 +550,7 @@ static void pflash_cfi02_realize(DeviceState *dev, Error
> **errp)
> pfl->wcycle = 0;
> pfl->cmd = 0;
> pfl->status = 0;
> +
> /* Hardcoded CFI table (mostly from SG29 Spansion flash) */
> /* Standard "QRY" string */
> pfl->cfi_table[0x10] = 'Q';
> @@ -575,7 +576,7 @@ static void pflash_cfi02_realize(DeviceState *dev, Error
> **errp)
> pfl->cfi_table[0x1D] = 0x00;
> /* Vpp max (no Vpp pin) */
> pfl->cfi_table[0x1E] = 0x00;
> - /* Reserved */
> + /* Timeout per single byte/word write (128 ms) */
> pfl->cfi_table[0x1F] = 0x07;
> /* Timeout for min size buffer write (NA) */
> pfl->cfi_table[0x20] = 0x00;
> @@ -614,17 +615,25 @@ static void pflash_cfi02_realize(DeviceState *dev,
> Error **errp)
> pfl->cfi_table[0x32] = 'R';
> pfl->cfi_table[0x33] = 'I';
>
> + /* Extended version 1.0 */
> pfl->cfi_table[0x34] = '1';
> pfl->cfi_table[0x35] = '0';
>
> + /* Address sensitive unlock required. */
> pfl->cfi_table[0x36] = 0x00;
> + /* Erase suspend not supported. */
> pfl->cfi_table[0x37] = 0x00;
> + /* Sector protect not supported. */
> pfl->cfi_table[0x38] = 0x00;
> + /* Temporary sector unprotect not supported. */
> pfl->cfi_table[0x39] = 0x00;
>
> + /* Sector protect/unprotect scheme. */
> pfl->cfi_table[0x3a] = 0x00;
>
> + /* Simultaneous operation not supported. */
> pfl->cfi_table[0x3b] = 0x00;
> + /* Burst mode not supported. */
> pfl->cfi_table[0x3c] = 0x00;
> }
>
> --
> 2.20.1
>
>
- Re: [Qemu-block] [Qemu-devel] [PATCH v5 11/28] hw/block/pflash_cfi02: Unify the MemoryRegionOps, (continued)
- [Qemu-block] [PATCH v5 10/28] hw/block/pflash_cfi02: Extract the pflash_data_read() function, Philippe Mathieu-Daudé, 2019/06/27
- [Qemu-block] [PATCH v5 12/28] hw/block/pflash_cfi02: Fix command address comparison, Philippe Mathieu-Daudé, 2019/06/27
- [Qemu-block] [PATCH v5 13/28] tests/pflash-cfi02: Refactor to support testing multiple configurations, Philippe Mathieu-Daudé, 2019/06/27
- [Qemu-block] [PATCH v5 14/28] hw/block/pflash_cfi02: Remove pointless local variable, Philippe Mathieu-Daudé, 2019/06/27
- [Qemu-block] [PATCH v5 15/28] hw/block/pflash_cfi02: Document the current CFI values, Philippe Mathieu-Daudé, 2019/06/27
- Re: [Qemu-block] [Qemu-devel] [PATCH v5 15/28] hw/block/pflash_cfi02: Document the current CFI values,
Alistair Francis <=
- [Qemu-block] [PATCH v5 16/28] hw/block/pflash_cfi02: Hold the PRI table offset in a variable, Philippe Mathieu-Daudé, 2019/06/27
- [Qemu-block] [PATCH v5 17/28] hw/block/pflash_cfi02: Document 'Page Mode' operations are not supported, Philippe Mathieu-Daudé, 2019/06/27
- [Qemu-block] [PATCH v5 18/28] hw/block/pflash_cfi02: Implement nonuniform sector sizes, Philippe Mathieu-Daudé, 2019/06/27
- [Qemu-block] [PATCH v5 20/28] hw/block/pflash_cfi02: Split if() condition, Philippe Mathieu-Daudé, 2019/06/27
- [Qemu-block] [PATCH v5 19/28] hw/block/pflash_cfi02: Extract pflash_regions_count(), Philippe Mathieu-Daudé, 2019/06/27