[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 6/7] file-posix: Add dynamic-auto-r
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 6/7] file-posix: Add dynamic-auto-read-only QAPI feature |
Date: |
Thu, 6 Jun 2019 10:54:16 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 6/6/19 10:38 AM, Markus Armbruster wrote:
> From: Kevin Wolf <address@hidden>
>
> In commit 23dece19da4 ('file-posix: Make auto-read-only dynamic') ,
> auto-read-only=on changed its behaviour in file-posix for the 4.0
> release. This change cannot be detected through the usual mechanisms
> like schema introspection. Add a new feature flag to the schema to
> allow libvirt to detect the presence of the new behaviour.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> qapi/block-core.json | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 1defcde048..f5e1ee91f9 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2859,6 +2859,15 @@
> # file is large, do not use in production.
> # (default: off) (since: 3.0)
> #
> +# Features:
> +# @dynamic-auto-read-only: If present, enabled auto-read-only means that the
> +# driver will open the image read-only at first,
> +# dynamically reopen the image file read-write when
> +# the first writer is attached to the node and
> reopen
> +# read-only when the last writer is detached. This
> +# allows to give QEMU write permissions only on
> demand
s/allows to give/allows giving/
> +# when an operation actually needs write access.
> +#
> # Since: 2.9
> ##
> { 'struct': 'BlockdevOptionsFile',
> @@ -2868,7 +2877,9 @@
> '*aio': 'BlockdevAioOptions',
> '*drop-cache': {'type': 'bool',
> 'if': 'defined(CONFIG_LINUX)'},
> - '*x-check-cache-dropped': 'bool' } }
> + '*x-check-cache-dropped': 'bool' },
> + 'features': [ { 'name': 'dynamic-auto-read-only',
> + 'if': 'defined(CONFIG_POSIX)' } ] }
>
> ##
> # @BlockdevOptionsNull:
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 0/7] file-posix: Add dynamic-auto-read-only QAPI feature, Markus Armbruster, 2019/06/06
- [Qemu-block] [PATCH 2/7] tests/qapi-schema: Test for good feature lists in structs, Markus Armbruster, 2019/06/06
- [Qemu-block] [PATCH 4/7] qapi: Disentangle QAPIDoc code, Markus Armbruster, 2019/06/06
- [Qemu-block] [PATCH 3/7] tests/qapi-schema: Error case tests for features in structs, Markus Armbruster, 2019/06/06
- [Qemu-block] [PATCH 6/7] file-posix: Add dynamic-auto-read-only QAPI feature, Markus Armbruster, 2019/06/06
- Re: [Qemu-block] [Qemu-devel] [PATCH 6/7] file-posix: Add dynamic-auto-read-only QAPI feature,
Eric Blake <=
- [Qemu-block] [PATCH 7/7] qapi: Simplify QAPIDoc implements its state machine, Markus Armbruster, 2019/06/06
- [Qemu-block] [PATCH 5/7] qapi: Allow documentation for features, Markus Armbruster, 2019/06/06
- [Qemu-block] [PATCH 1/7] qapi: Add feature flags to struct types, Markus Armbruster, 2019/06/06
- Re: [Qemu-block] [PATCH 0/7] file-posix: Add dynamic-auto-read-only QAPI feature, Kevin Wolf, 2019/06/07
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/7] file-posix: Add dynamic-auto-read-only QAPI feature, Markus Armbruster, 2019/06/12