[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 0/7] file-posix: Add dynamic-auto-read-only QAPI fea
From: |
Markus Armbruster |
Subject: |
[Qemu-block] [PATCH 0/7] file-posix: Add dynamic-auto-read-only QAPI feature |
Date: |
Thu, 6 Jun 2019 17:37:56 +0200 |
This series adds optional feature lists to struct definitions in the
QAPI schema and makes use of them to advertise the new behaviour of
auto-read-only=on in file-posix.
v5:
- PATCH 4: restore a lost comment line, clean up comment whitespace
for PEP 8
- PATCH 4+5: replace QAPIDoc._check_named_section() by
._is_section_tag()
- PATCH 7: New
v4:
- Build fix for tests/test-qmp-cmds
v3:
- Added a command using the structs types to the positive test case
- Renamed QAPIDoc.SymbolPart to QAPIDoc.DocPart
- Applied requested comment changes
- Style fixes to avoid adding pycodestyle-3 complaints
- More stylistic changes to match Markus' taste better
v2:
- Check that features have well-formed names instead of just checking
that they are strings
- Use QAPISchemaFeature objects instead of dicts
- Catch duplicate feature names (and test that a feature name doesn't
conflict with an object member)
- Added patch 4 and 5 to add rudimentary support for features to
QAPIDoc so it doesn't complain about the documentation format
suggested by Markus. Used that format in the documentation of
dynamic-auto-read-only.
Kevin Wolf (6):
qapi: Add feature flags to struct types
tests/qapi-schema: Test for good feature lists in structs
tests/qapi-schema: Error case tests for features in structs
qapi: Disentangle QAPIDoc code
qapi: Allow documentation for features
file-posix: Add dynamic-auto-read-only QAPI feature
Markus Armbruster (1):
qapi: Simplify QAPIDoc implements its state machine
docs/devel/qapi-code-gen.txt | 38 +++
qapi/block-core.json | 13 +-
qapi/introspect.json | 6 +-
scripts/qapi/common.py | 243 +++++++++++++++---
scripts/qapi/doc.py | 15 +-
scripts/qapi/introspect.py | 6 +-
scripts/qapi/types.py | 3 +-
scripts/qapi/visit.py | 3 +-
tests/Makefile.include | 6 +
tests/qapi-schema/double-type.err | 2 +-
tests/qapi-schema/features-bad-type.err | 1 +
tests/qapi-schema/features-bad-type.exit | 1 +
tests/qapi-schema/features-bad-type.json | 3 +
tests/qapi-schema/features-bad-type.out | 0
tests/qapi-schema/features-duplicate-name.err | 1 +
.../qapi-schema/features-duplicate-name.exit | 1 +
.../qapi-schema/features-duplicate-name.json | 3 +
tests/qapi-schema/features-duplicate-name.out | 0
tests/qapi-schema/features-missing-name.err | 1 +
tests/qapi-schema/features-missing-name.exit | 1 +
tests/qapi-schema/features-missing-name.json | 3 +
tests/qapi-schema/features-missing-name.out | 0
tests/qapi-schema/features-name-bad-type.err | 1 +
tests/qapi-schema/features-name-bad-type.exit | 1 +
tests/qapi-schema/features-name-bad-type.json | 3 +
tests/qapi-schema/features-name-bad-type.out | 0
tests/qapi-schema/features-no-list.err | 1 +
tests/qapi-schema/features-no-list.exit | 1 +
tests/qapi-schema/features-no-list.json | 3 +
tests/qapi-schema/features-no-list.out | 0
tests/qapi-schema/features-unknown-key.err | 2 +
tests/qapi-schema/features-unknown-key.exit | 1 +
tests/qapi-schema/features-unknown-key.json | 3 +
tests/qapi-schema/features-unknown-key.out | 0
tests/qapi-schema/qapi-schema-test.json | 39 +++
tests/qapi-schema/qapi-schema-test.out | 43 ++++
tests/qapi-schema/test-qapi.py | 7 +-
tests/qapi-schema/unknown-expr-key.err | 2 +-
tests/test-qmp-cmds.c | 8 +
39 files changed, 419 insertions(+), 46 deletions(-)
create mode 100644 tests/qapi-schema/features-bad-type.err
create mode 100644 tests/qapi-schema/features-bad-type.exit
create mode 100644 tests/qapi-schema/features-bad-type.json
create mode 100644 tests/qapi-schema/features-bad-type.out
create mode 100644 tests/qapi-schema/features-duplicate-name.err
create mode 100644 tests/qapi-schema/features-duplicate-name.exit
create mode 100644 tests/qapi-schema/features-duplicate-name.json
create mode 100644 tests/qapi-schema/features-duplicate-name.out
create mode 100644 tests/qapi-schema/features-missing-name.err
create mode 100644 tests/qapi-schema/features-missing-name.exit
create mode 100644 tests/qapi-schema/features-missing-name.json
create mode 100644 tests/qapi-schema/features-missing-name.out
create mode 100644 tests/qapi-schema/features-name-bad-type.err
create mode 100644 tests/qapi-schema/features-name-bad-type.exit
create mode 100644 tests/qapi-schema/features-name-bad-type.json
create mode 100644 tests/qapi-schema/features-name-bad-type.out
create mode 100644 tests/qapi-schema/features-no-list.err
create mode 100644 tests/qapi-schema/features-no-list.exit
create mode 100644 tests/qapi-schema/features-no-list.json
create mode 100644 tests/qapi-schema/features-no-list.out
create mode 100644 tests/qapi-schema/features-unknown-key.err
create mode 100644 tests/qapi-schema/features-unknown-key.exit
create mode 100644 tests/qapi-schema/features-unknown-key.json
create mode 100644 tests/qapi-schema/features-unknown-key.out
--
2.21.0
- [Qemu-block] [PATCH 0/7] file-posix: Add dynamic-auto-read-only QAPI feature,
Markus Armbruster <=
- [Qemu-block] [PATCH 2/7] tests/qapi-schema: Test for good feature lists in structs, Markus Armbruster, 2019/06/06
- [Qemu-block] [PATCH 4/7] qapi: Disentangle QAPIDoc code, Markus Armbruster, 2019/06/06
- [Qemu-block] [PATCH 3/7] tests/qapi-schema: Error case tests for features in structs, Markus Armbruster, 2019/06/06
- [Qemu-block] [PATCH 6/7] file-posix: Add dynamic-auto-read-only QAPI feature, Markus Armbruster, 2019/06/06
- [Qemu-block] [PATCH 7/7] qapi: Simplify QAPIDoc implements its state machine, Markus Armbruster, 2019/06/06
- [Qemu-block] [PATCH 5/7] qapi: Allow documentation for features, Markus Armbruster, 2019/06/06
- [Qemu-block] [PATCH 1/7] qapi: Add feature flags to struct types, Markus Armbruster, 2019/06/06
- Re: [Qemu-block] [PATCH 0/7] file-posix: Add dynamic-auto-read-only QAPI feature, Kevin Wolf, 2019/06/07