[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/18] qapi/crypto: Drop unwanted 'prefix'
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH 10/18] qapi/crypto: Drop unwanted 'prefix' |
|
Date: |
Tue, 30 Jul 2024 09:58:11 +0100 |
|
User-agent: |
Mutt/2.2.12 (2023-09-09) |
On Tue, Jul 30, 2024 at 10:10:24AM +0200, Markus Armbruster wrote:
> QAPI's 'prefix' feature can make the connection between enumeration
> type and its constants less than obvious. It's best used with
> restraint.
>
> QCryptoAkCipherKeyType has a 'prefix' that overrides the generated
> enumeration constants' prefix to QCRYPTO_AKCIPHER_KEY_TYPE.
>
> Drop it. The prefix becomes QCRYPTO_AK_CIPHER_KEY_TYPE.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qapi/crypto.json | 1 -
> backends/cryptodev-builtin.c | 4 ++--
> backends/cryptodev-lkcf.c | 6 +++---
> tests/bench/benchmark-crypto-akcipher.c | 2 +-
> tests/unit/test-crypto-akcipher.c | 28 ++++++++++++-------------
> crypto/akcipher-gcrypt.c.inc | 8 +++----
> crypto/akcipher-nettle.c.inc | 8 +++----
> crypto/rsakey-builtin.c.inc | 4 ++--
> crypto/rsakey-nettle.c.inc | 4 ++--
> 9 files changed, 32 insertions(+), 33 deletions(-)
Acked-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 02/18] tests/qapi-schema: Drop temporary 'prefix', (continued)
- [PATCH 02/18] tests/qapi-schema: Drop temporary 'prefix', Markus Armbruster, 2024/07/30
- [PATCH 01/18] qapi: Smarter camel_to_upper() to reduce need for 'prefix', Markus Armbruster, 2024/07/30
- [PATCH 09/18] qapi/machine: Rename CpuS390* to S390Cpu, and drop 'prefix', Markus Armbruster, 2024/07/30
- [PATCH 15/18] qapi/crypto: Rename QCryptoRSAPaddingAlgorithm to *Algo, and drop prefix, Markus Armbruster, 2024/07/30
- [PATCH 10/18] qapi/crypto: Drop unwanted 'prefix', Markus Armbruster, 2024/07/30
- Re: [PATCH 10/18] qapi/crypto: Drop unwanted 'prefix',
Daniel P . Berrangé <=
- [PATCH 14/18] qapi/crypto: Rename QCryptoAkCipherAlgorithm to *Algo, and drop prefix, Markus Armbruster, 2024/07/30
- [PATCH 05/18] qapi/crypto: Drop temporary 'prefix', Markus Armbruster, 2024/07/30
- [PATCH 04/18] qapi/common: Drop temporary 'prefix', Markus Armbruster, 2024/07/30
- [PATCH 17/18] qapi/cryptodev: Drop unwanted 'prefix', Markus Armbruster, 2024/07/30
- [PATCH 12/18] qapi/crypto: Rename QCryptoCipherAlgorithm to *Algo, and drop prefix, Markus Armbruster, 2024/07/30