[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/18] qapi/crypto: Drop temporary 'prefix'
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH 05/18] qapi/crypto: Drop temporary 'prefix' |
|
Date: |
Tue, 30 Jul 2024 09:57:03 +0100 |
|
User-agent: |
Mutt/2.2.12 (2023-09-09) |
On Tue, Jul 30, 2024 at 10:10:19AM +0200, Markus Armbruster wrote:
> Recent commit "qapi: Smarter camel_to_upper() to reduce need for
> 'prefix'" added two temporary 'prefix' to delay changing the generated
> code.
>
> Revert them. This improves QCryptoBlockFormat's generated enumeration
> constant prefix from Q_CRYPTO_BLOCK_FORMAT to QCRYPTO_BLOCK_FORMAT,
> and QCryptoBlockLUKSKeyslotState's from
> Q_CRYPTO_BLOCKLUKS_KEYSLOT_STATE to QCRYPTO_BLOCK_LUKS_KEYSLOT_STATE.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qapi/crypto.json | 2 --
> block/crypto.c | 10 +++++-----
> block/qcow.c | 2 +-
> block/qcow2.c | 10 +++++-----
> crypto/block-luks.c | 4 ++--
> crypto/block.c | 4 ++--
> tests/unit/test-crypto-block.c | 14 +++++++-------
> 7 files changed, 22 insertions(+), 24 deletions(-)
Acked-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 09/18] qapi/machine: Rename CpuS390* to S390Cpu, and drop 'prefix', (continued)
- [PATCH 09/18] qapi/machine: Rename CpuS390* to S390Cpu, and drop 'prefix', Markus Armbruster, 2024/07/30
- [PATCH 15/18] qapi/crypto: Rename QCryptoRSAPaddingAlgorithm to *Algo, and drop prefix, Markus Armbruster, 2024/07/30
- [PATCH 10/18] qapi/crypto: Drop unwanted 'prefix', Markus Armbruster, 2024/07/30
- [PATCH 14/18] qapi/crypto: Rename QCryptoAkCipherAlgorithm to *Algo, and drop prefix, Markus Armbruster, 2024/07/30
- [PATCH 05/18] qapi/crypto: Drop temporary 'prefix', Markus Armbruster, 2024/07/30
- Re: [PATCH 05/18] qapi/crypto: Drop temporary 'prefix',
Daniel P . Berrangé <=
- [PATCH 04/18] qapi/common: Drop temporary 'prefix', Markus Armbruster, 2024/07/30
- [PATCH 17/18] qapi/cryptodev: Drop unwanted 'prefix', Markus Armbruster, 2024/07/30
- [PATCH 12/18] qapi/crypto: Rename QCryptoCipherAlgorithm to *Algo, and drop prefix, Markus Armbruster, 2024/07/30
- [PATCH 18/18] qapi/cryptodev: Rename QCryptodevBackendAlgType to *Algo, and drop prefix, Markus Armbruster, 2024/07/30
- [PATCH 11/18] qapi/crypto: Rename QCryptoHashAlgorithm to *Algo, and drop prefix, Markus Armbruster, 2024/07/30