Re: [PATCH 03/10] tests/avocado/intel_iommu.py: increase timeout

[Philippe Mathieu-Daudé]

On 14/12/23 08:24, Eric Auger wrote:
> Hi Cleber,
>
> On 12/13/23 21:08, Cleber Rosa wrote:
> > Alex Bennée <alex.bennee@linaro.org> writes:
> >
> > > Cleber Rosa <crosa@redhat.com> writes:
> > >
> > > > Based on many runs, the average run time for these 4 tests is around
> > > > 250 seconds, with 320 seconds being the ceiling.  In any way, the
> > > > default 120 seconds timeout is inappropriate in my experience.
> > > I would rather see these tests updated to fix:
> > >
> > >   - Don't use such an old Fedora 31 image
> > I remember proposing a bump in Fedora version used by default in
> > avocado_qemu.LinuxTest (which would propagate to tests such as
> > boot_linux.py and others), but that was not well accepted.  I can
> > definitely work on such a version bump again.
> >
> > >   - Avoid updating image packages (when will RH stop serving them?)
> > IIUC the only reason for updating the packages is to test the network
> > from the guest, and could/should be done another way.
> >
> > Eric, could you confirm this?
> Sorry for the delay. Yes effectively I used the dnf install to stress
> the viommu. In the past I was able to trigger viommu bugs that way
> whereas getting an IP @ for the guest was just successful.

Maybe this test is useful as what Daniel described as "Tier 2" [*],
that maintainers run locally but don't need to be gating CI? That
would save us some resources there.

[*] https://lore.kernel.org/qemu-devel/20200427152036.GI1244803@redhat.com/

> > >   - The "test" is a fairly basic check of dmesg/sysfs output
> > Maybe the network is also an implicit check here.  Let's see what Eric
> > has to say.
>
> To be honest I do not remember how avocado does the check in itself; my
> guess if that if the dnf install does not complete you get a timeout and
> the test fails. But you may be more knowledged on this than me ;-)
>
> Thanks
>
> Eric