Re: [PATCH 07/10] testa/avocado: test_arm_emcraft_sf2: handle RW requirements for asset

[Akihiko Odaki]

On 2023/12/12 1:36, Philippe Mathieu-Daudé wrote:
> On 8/12/23 20:09, Cleber Rosa wrote:
> > The asset used in the mentioned test gets truncated before it's used
> > in the test.  This means that the file gets modified, and thus the
> > asset's expected hash doesn't match anymore.  This causes cache misses
> > and re-downloads every time the test is re-run.
> >
> > Let's make a copy of the asset so that the one in the cache is
> > preserved and the cache sees a hit on re-runs.
> >
> > Signed-off-by: Cleber Rosa <crosa@redhat.com>
> > ---
> >   tests/avocado/boot_linux_console.py | 6 ++++--
> >   1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/avocado/boot_linux_console.py 
> > b/tests/avocado/boot_linux_console.py
> > index f5c5d647a4..e2e928e703 100644
> > --- a/tests/avocado/boot_linux_console.py
> > +++ b/tests/avocado/boot_linux_console.py
> > @@ -414,14 +414,16 @@ def test_arm_emcraft_sf2(self):
> >                      'fe371d32e50ca682391e1e70ab98c2942aeffb01/spi.bin')
> >           spi_hash = '65523a1835949b6f4553be96dec1b6a38fb05501'
> >           spi_path = self.fetch_asset(spi_url, asset_hash=spi_hash)
> > +        spi_path_rw = os.path.join(self.workdir, 
> > os.path.basename(spi_path))
> > +        shutil.copy(spi_path, spi_path_rw)
>
> This is an implementation detail. By default fetch_asset() should return
> a path to a read-only artifact. We should extend it to optionally return
> a writable file path, with the possibility to provide a dir/path.

Apparently it is not OK to abstract fetch_asset() away; it confuses some 
static analysis according to:
"[PATCH 02/10] tests/avocado: mips: add hint for fetchasset plugin"

That said, it is still nice to have a method that does os.path.join() 
and shutil.copy().