qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 11/12] gdbstub: replace global gdb_has_xml with a function


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 11/12] gdbstub: replace global gdb_has_xml with a function
Date: Fri, 25 Aug 2023 09:33:21 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0

On 24/8/23 18:39, Alex Bennée wrote:
Try and make the self reported global hack a little less hackish by
providing a query function instead. As gdb_has_xml was always set if
we negotiated XML we can now use the presence of ->target_xml as the
test instead.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
  gdbstub/internals.h    |  1 +
  include/exec/gdbstub.h | 10 +++++-----
  gdbstub/gdbstub.c      | 12 +++++++-----
  gdbstub/softmmu.c      |  1 -
  gdbstub/user.c         |  1 -
  target/arm/gdbstub.c   |  8 ++++----
  target/ppc/gdbstub.c   |  4 ++--
  7 files changed, 19 insertions(+), 18 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]