[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 12/12] gdbstub: move comment for gdb_register_coprocessor
From: |
Alex Bennée |
Subject: |
[PATCH v2 12/12] gdbstub: move comment for gdb_register_coprocessor |
Date: |
Thu, 24 Aug 2023 17:39:10 +0100 |
Use proper kdoc style comments for this API function.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
include/exec/gdbstub.h | 10 ++++++++++
gdbstub/gdbstub.c | 6 ------
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h
index 0ee39cfdd1..16a139043f 100644
--- a/include/exec/gdbstub.h
+++ b/include/exec/gdbstub.h
@@ -14,6 +14,16 @@
/* Get or set a register. Returns the size of the register. */
typedef int (*gdb_get_reg_cb)(CPUArchState *env, GByteArray *buf, int reg);
typedef int (*gdb_set_reg_cb)(CPUArchState *env, uint8_t *buf, int reg);
+
+/**
+ * gdb_register_coprocessor() - register a supplemental set of registers
+ * @cpu - the CPU associated with registers
+ * @get_reg - get function (gdb reading)
+ * @set_reg - set function (gdb modifying)
+ * @num_regs - number of registers in set
+ * @xml - xml name of set
+ * @gpos - non-zero to append to "general" register set at @gpos
+ */
void gdb_register_coprocessor(CPUState *cpu,
gdb_get_reg_cb get_reg, gdb_set_reg_cb set_reg,
int num_regs, const char *xml, int g_pos);
diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c
index 10fb755390..1fb0db747f 100644
--- a/gdbstub/gdbstub.c
+++ b/gdbstub/gdbstub.c
@@ -450,12 +450,6 @@ static int gdb_write_register(CPUState *cpu, uint8_t
*mem_buf, int reg)
return 0;
}
-/* Register a supplemental set of CPU registers. If g_pos is nonzero it
- specifies the first register number and these registers are included in
- a standard "g" packet. Direction is relative to gdb, i.e. get_reg is
- gdb reading a CPU register, and set_reg is gdb modifying a CPU register.
- */
-
void gdb_register_coprocessor(CPUState *cpu,
gdb_get_reg_cb get_reg, gdb_set_reg_cb set_reg,
int num_regs, const char *xml, int g_pos)
--
2.39.2
- Re: [PATCH v2 01/12] gitlab: enable ccache for many build jobs, (continued)
[PATCH v2 04/12] docs/style: permit inline loop variables, Alex Bennée, 2023/08/24
[PATCH v2 06/12] tests: remove test-gdbstub.py, Alex Bennée, 2023/08/24
[PATCH v2 08/12] gdbstub: fixes cases where wrong threads were reported to GDB on SIGINT, Alex Bennée, 2023/08/24
[PATCH v2 07/12] tests/tcg: clean-up gdb confirm/pagination settings, Alex Bennée, 2023/08/24
[PATCH v2 09/12] gdbstub: remove unused user_ctx field, Alex Bennée, 2023/08/24
[PATCH v2 12/12] gdbstub: move comment for gdb_register_coprocessor,
Alex Bennée <=
[PATCH v2 11/12] gdbstub: replace global gdb_has_xml with a function, Alex Bennée, 2023/08/24
[PATCH v2 10/12] gdbstub: refactor get_feature_xml, Alex Bennée, 2023/08/24