Re: [PATCH v2 04/12] hw/ssi: Add an "addr" property to SSIPeripheral

[Cédric Le Goater]

On 6/29/23 12:56, Philippe Mathieu-Daudé wrote:
> On 7/6/23 16:15, Cédric Le Goater wrote:
> > On 6/7/23 10:28, Philippe Mathieu-Daudé wrote:
> > > On 7/6/23 10:06, Joel Stanley wrote:
> > > > On Wed, 7 Jun 2023 at 04:40, Cédric Le Goater <clg@kaod.org> wrote:
> > > > > Boards will use this new property to identify the device CS line and
> > > > > wire the SPI controllers accordingly.
> > > >
> > > > "addr" and not "cs" or even "chip-select"?
> > >
> > > "chip-select" is a good suggestion!
> >
> > I thought of using "cs" initially as it makes more sense for SPI
> > controllers, I do agree. But then, I tried to be consistent with
> > what QEMU is proposing today : "bus" and "addr".
>
> We should use a description that stays close with the terms used
> by the hardware we model. In that case "cs" seems more appropriate.

OK. I can change the property to "cs".

Thanks,

C.