Re: [PATCH v2 04/12] hw/ssi: Add an "addr" property to SSIPeripheral

[Cédric Le Goater]

On 6/7/23 10:28, Philippe Mathieu-Daudé wrote:
> On 7/6/23 10:06, Joel Stanley wrote:
> > On Wed, 7 Jun 2023 at 04:40, Cédric Le Goater <clg@kaod.org> wrote:
> > > Boards will use this new property to identify the device CS line and
> > > wire the SPI controllers accordingly.
> >
> > "addr" and not "cs" or even "chip-select"?
>
> "chip-select" is a good suggestion!

I thought of using "cs" initially as it makes more sense for SPI
controllers, I do agree. But then, I tried to be consistent with
what QEMU is proposing today : "bus" and "addr".

This can be changed.

Thanks,

C.

> > Reviewed-by: Joel Stanley <joel@jms.id.au>
> >
> > > Cc: Alistair Francis <alistair@alistair23.me>
> > > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > > Signed-off-by: Cédric Le Goater <clg@kaod.org>
> > > ---
> > >   include/hw/ssi/ssi.h | 3 +++
> > >   hw/ssi/ssi.c         | 7 +++++++
> > >   2 files changed, 10 insertions(+)