On Wed, Jun 21, 2023 at 5:44 AM Lucas Villa Real <lucas@osdyne.com> wrote:
>
> Add support for FSMC on high-density STM32F100 devices and enable
> mapping of additional memory via the `-m SIZE` command-line option.
> FSMC Bank1 can address up to 4x64MB of PSRAM memory at 0x60000000.
Thanks for the patches!
You're welcome!
>
> RCC is needed to enable peripheral clock for FSMC; this commit
> implements support for RCC through the MMIO interface.
This should be a separate commit. The idea is to break commits up as
small as possible and send a patch series, this makes review much
easier. Each new feature should be its own commit.
Thanks, I'll submit a new patchset as recommended.
>
> Last, high-density devices support up to 32KB of static SRAM, so
> adjust SRAM_SIZE accordingly.
Also, can you include a link to the documentation in the commit message?
Absolutely.
> +static const MemoryRegionOps stm32f100_rcc_ops = {
> + .read = stm32f100_rcc_read,
> + .write = stm32f100_rcc_write,
> + .endianness = DEVICE_NATIVE_ENDIAN,
> +};
This should be its own file and device that is included
Sounds good, thanks for the guidance. I'll work on this next week.