[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 07/10] hw/i386/acpi-build: Rely on machine->device_memory when
From: |
David Hildenbrand |
Subject: |
[PATCH v4 07/10] hw/i386/acpi-build: Rely on machine->device_memory when building SRAT |
Date: |
Fri, 23 Jun 2023 14:45:50 +0200 |
We're already looking at machine->device_memory when calling
build_srat_memory(), so let's simply avoid going via
PC_MACHINE_DEVMEM_REGION_SIZE to get the size and rely on
machine->device_memory directly.
Once machine->device_memory is set, we know that the size > 0. The code now
looks much more similar the hw/arm/virt-acpi-build.c variant.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Richard Henderson <richard.henderson@linaro.org>
Cc: Eduardo Habkost <eduardo@habkost.net>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/i386/acpi-build.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 512162003b..9c74fa17ad 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1950,12 +1950,8 @@ build_srat(GArray *table_data, BIOSLinker *linker,
MachineState *machine)
MachineClass *mc = MACHINE_GET_CLASS(machine);
X86MachineState *x86ms = X86_MACHINE(machine);
const CPUArchIdList *apic_ids = mc->possible_cpu_arch_ids(machine);
- PCMachineState *pcms = PC_MACHINE(machine);
int nb_numa_nodes = machine->numa_state->num_nodes;
NodeInfo *numa_info = machine->numa_state->nodes;
- ram_addr_t hotpluggable_address_space_size =
- object_property_get_int(OBJECT(pcms), PC_MACHINE_DEVMEM_REGION_SIZE,
- NULL);
AcpiTable table = { .sig = "SRAT", .rev = 1, .oem_id = x86ms->oem_id,
.oem_table_id = x86ms->oem_table_id };
@@ -2071,9 +2067,10 @@ build_srat(GArray *table_data, BIOSLinker *linker,
MachineState *machine)
* Memory devices may override proximity set by this entry,
* providing _PXM method if necessary.
*/
- if (hotpluggable_address_space_size) {
+ if (machine->device_memory) {
build_srat_memory(table_data, machine->device_memory->base,
- hotpluggable_address_space_size, nb_numa_nodes - 1,
+ memory_region_size(&machine->device_memory->mr),
+ nb_numa_nodes - 1,
MEM_AFFINITY_HOTPLUGGABLE | MEM_AFFINITY_ENABLED);
}
--
2.40.1
- [PATCH v4 00/10] memory-device: Some cleanups, David Hildenbrand, 2023/06/23
- [PATCH v4 01/10] memory-device: Unify enabled vs. supported error messages, David Hildenbrand, 2023/06/23
- [PATCH v4 02/10] memory-device: Introduce machine_memory_devices_init(), David Hildenbrand, 2023/06/23
- [PATCH v4 03/10] hw/arm/virt: Use machine_memory_devices_init(), David Hildenbrand, 2023/06/23
- [PATCH v4 04/10] hw/ppc/spapr: Use machine_memory_devices_init(), David Hildenbrand, 2023/06/23
- [PATCH v4 05/10] hw/loongarch/virt: Use machine_memory_devices_init(), David Hildenbrand, 2023/06/23
- [PATCH v4 06/10] hw/i386/pc: Use machine_memory_devices_init(), David Hildenbrand, 2023/06/23
- [PATCH v4 07/10] hw/i386/acpi-build: Rely on machine->device_memory when building SRAT,
David Hildenbrand <=
- [PATCH v4 08/10] hw/i386/pc: Remove PC_MACHINE_DEVMEM_REGION_SIZE, David Hildenbrand, 2023/06/23
- [PATCH v4 09/10] memory-device: Refactor memory_device_pre_plug(), David Hildenbrand, 2023/06/23
- [PATCH v4 10/10] memory-device: Track used region size in DeviceMemoryState, David Hildenbrand, 2023/06/23
- Re: [PATCH v4 00/10] memory-device: Some cleanups, David Hildenbrand, 2023/06/27