[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 05/10] hw/loongarch/virt: Use machine_memory_devices_init()
From: |
David Hildenbrand |
Subject: |
[PATCH v4 05/10] hw/loongarch/virt: Use machine_memory_devices_init() |
Date: |
Fri, 23 Jun 2023 14:45:48 +0200 |
Let's use our new helper. While at it, use VIRT_HIGHMEM_BASE.
Cc: Xiaojuan Yang <yangxiaojuan@loongson.cn>
Cc: Song Gao <gaosong@loongson.cn>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Song Gao <gaosong@loongson.cn>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/loongarch/virt.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c
index ca8824b6ef..4a42a8119a 100644
--- a/hw/loongarch/virt.c
+++ b/hw/loongarch/virt.c
@@ -863,8 +863,8 @@ static void loongarch_init(MachineState *machine)
/* initialize device memory address space */
if (machine->ram_size < machine->maxram_size) {
- machine->device_memory = g_malloc0(sizeof(*machine->device_memory));
ram_addr_t device_mem_size = machine->maxram_size - machine->ram_size;
+ hwaddr device_mem_base;
if (machine->ram_slots > ACPI_MAX_RAM_SLOTS) {
error_report("unsupported amount of memory slots: %"PRIu64,
@@ -879,14 +879,8 @@ static void loongarch_init(MachineState *machine)
exit(EXIT_FAILURE);
}
/* device memory base is the top of high memory address. */
- machine->device_memory->base = 0x90000000 + highram_size;
- machine->device_memory->base =
- ROUND_UP(machine->device_memory->base, 1 * GiB);
-
- memory_region_init(&machine->device_memory->mr, OBJECT(lams),
- "device-memory", device_mem_size);
- memory_region_add_subregion(address_space_mem,
machine->device_memory->base,
- &machine->device_memory->mr);
+ device_mem_base = ROUND_UP(VIRT_HIGHMEM_BASE + highram_size, 1 * GiB);
+ machine_memory_devices_init(machine, device_mem_base, device_mem_size);
}
/* Add isa io region */
--
2.40.1
- [PATCH v4 00/10] memory-device: Some cleanups, David Hildenbrand, 2023/06/23
- [PATCH v4 01/10] memory-device: Unify enabled vs. supported error messages, David Hildenbrand, 2023/06/23
- [PATCH v4 02/10] memory-device: Introduce machine_memory_devices_init(), David Hildenbrand, 2023/06/23
- [PATCH v4 03/10] hw/arm/virt: Use machine_memory_devices_init(), David Hildenbrand, 2023/06/23
- [PATCH v4 04/10] hw/ppc/spapr: Use machine_memory_devices_init(), David Hildenbrand, 2023/06/23
- [PATCH v4 05/10] hw/loongarch/virt: Use machine_memory_devices_init(),
David Hildenbrand <=
- [PATCH v4 06/10] hw/i386/pc: Use machine_memory_devices_init(), David Hildenbrand, 2023/06/23
- [PATCH v4 07/10] hw/i386/acpi-build: Rely on machine->device_memory when building SRAT, David Hildenbrand, 2023/06/23
- [PATCH v4 08/10] hw/i386/pc: Remove PC_MACHINE_DEVMEM_REGION_SIZE, David Hildenbrand, 2023/06/23
- [PATCH v4 09/10] memory-device: Refactor memory_device_pre_plug(), David Hildenbrand, 2023/06/23
- [PATCH v4 10/10] memory-device: Track used region size in DeviceMemoryState, David Hildenbrand, 2023/06/23
- Re: [PATCH v4 00/10] memory-device: Some cleanups, David Hildenbrand, 2023/06/27