[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 4/7] hw/usb/hcd-xhci: Use sysbus_init_irqs()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 4/7] hw/usb/hcd-xhci: Use sysbus_init_irqs() |
Date: |
Thu, 1 Jun 2023 11:46:22 +0200 |
The SYSBUS_DEVICE_GPIO_IRQ definition should be internal to
the SysBus API. Use the recently introduced sysbus_init_irqs()
method to avoid using this internal definition.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
hw/usb/hcd-xhci-sysbus.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/usb/hcd-xhci-sysbus.c b/hw/usb/hcd-xhci-sysbus.c
index faf57b4797..e512849b34 100644
--- a/hw/usb/hcd-xhci-sysbus.c
+++ b/hw/usb/hcd-xhci-sysbus.c
@@ -40,9 +40,6 @@ static void xhci_sysbus_realize(DeviceState *dev, Error
**errp)
if (!qdev_realize(DEVICE(&s->xhci), NULL, errp)) {
return;
}
- s->irq = g_new0(qemu_irq, s->xhci.numintrs);
- qdev_init_gpio_out_named(dev, s->irq, SYSBUS_DEVICE_GPIO_IRQ,
- s->xhci.numintrs);
if (s->xhci.dma_mr) {
s->xhci.as = g_malloc0(sizeof(AddressSpace));
address_space_init(s->xhci.as, s->xhci.dma_mr, NULL);
@@ -50,6 +47,8 @@ static void xhci_sysbus_realize(DeviceState *dev, Error
**errp)
s->xhci.as = &address_space_memory;
}
+ s->irq = g_new0(qemu_irq, s->xhci.numintrs);
+ sysbus_init_irqs(SYS_BUS_DEVICE(dev), s->irq, s->xhci.numintrs);
sysbus_init_mmio(SYS_BUS_DEVICE(dev), &s->xhci.mem);
}
--
2.38.1
- [PATCH v2 0/7] hw/sysbus: Add sysbus_init_irqs and reduce SYSBUS_DEVICE_GPIO_IRQ scope, Philippe Mathieu-Daudé, 2023/06/01
- [PATCH v2 1/7] hw/arm/xlnx-versal: Do not open-code sysbus_connect_irq(), Philippe Mathieu-Daudé, 2023/06/01
- [PATCH v2 2/7] hw/usb/xlnx: Do not open-code sysbus_pass_irq(), Philippe Mathieu-Daudé, 2023/06/01
- [PATCH v2 3/7] hw/sysbus: Introduce sysbus_init_irqs(), Philippe Mathieu-Daudé, 2023/06/01
- [PATCH v2 4/7] hw/usb/hcd-xhci: Use sysbus_init_irqs(),
Philippe Mathieu-Daudé <=
- [PATCH v2 5/7] hw/sysbus: Make SYSBUS_DEVICE_GPIO_IRQ API internal, Philippe Mathieu-Daudé, 2023/06/01
- [PATCH v2 7/7] hw: Simplify using sysbus_init_irqs() [manual], Philippe Mathieu-Daudé, 2023/06/01
- [PATCH v2 6/7] hw: Simplify using sysbus_init_irqs() [automatic], Philippe Mathieu-Daudé, 2023/06/01