[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/7] hw/arm/xlnx-versal: Do not open-code sysbus_connect_irq()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 1/7] hw/arm/xlnx-versal: Do not open-code sysbus_connect_irq() |
Date: |
Thu, 1 Jun 2023 11:46:19 +0200 |
The SYSBUS_DEVICE_GPIO_IRQ definition should be internal to
the SysBus API. Here we simply open-coded sysbus_connect_irq().
Replace to use the proper API.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
hw/arm/xlnx-versal.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c
index db1e0dee6e..79133afa71 100644
--- a/hw/arm/xlnx-versal.c
+++ b/hw/arm/xlnx-versal.c
@@ -704,9 +704,7 @@ static void versal_unimp(Versal *s)
gpio_in);
gpio_in = qdev_get_gpio_in_named(DEVICE(s), "irq-parity-imr-dummy", 0);
- qdev_connect_gpio_out_named(DEVICE(&s->pmc.iou.slcr),
- SYSBUS_DEVICE_GPIO_IRQ, 0,
- gpio_in);
+ sysbus_connect_irq(SYS_BUS_DEVICE(&s->pmc.iou.slcr), 0, gpio_in);
}
static void versal_realize(DeviceState *dev, Error **errp)
--
2.38.1
- [PATCH v2 0/7] hw/sysbus: Add sysbus_init_irqs and reduce SYSBUS_DEVICE_GPIO_IRQ scope, Philippe Mathieu-Daudé, 2023/06/01
- [PATCH v2 1/7] hw/arm/xlnx-versal: Do not open-code sysbus_connect_irq(),
Philippe Mathieu-Daudé <=
- [PATCH v2 2/7] hw/usb/xlnx: Do not open-code sysbus_pass_irq(), Philippe Mathieu-Daudé, 2023/06/01
- [PATCH v2 3/7] hw/sysbus: Introduce sysbus_init_irqs(), Philippe Mathieu-Daudé, 2023/06/01
- [PATCH v2 4/7] hw/usb/hcd-xhci: Use sysbus_init_irqs(), Philippe Mathieu-Daudé, 2023/06/01
- [PATCH v2 5/7] hw/sysbus: Make SYSBUS_DEVICE_GPIO_IRQ API internal, Philippe Mathieu-Daudé, 2023/06/01
- [PATCH v2 7/7] hw: Simplify using sysbus_init_irqs() [manual], Philippe Mathieu-Daudé, 2023/06/01
- [PATCH v2 6/7] hw: Simplify using sysbus_init_irqs() [automatic], Philippe Mathieu-Daudé, 2023/06/01