Re: [PATCH v2 33/33] target/arm: Enable TARGET_TB_PCREL

[Richard Henderson]

On 8/16/22 15:34, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   target/arm/cpu-param.h     |  2 ++
>   target/arm/translate.h     |  6 ++++
>   target/arm/cpu.c           | 23 +++++++-------
>   target/arm/translate-a64.c | 37 ++++++++++++++++++-----
>   target/arm/translate.c     | 62 ++++++++++++++++++++++++++++++--------
>   5 files changed, 100 insertions(+), 30 deletions(-)
>
> diff --git a/target/arm/cpu-param.h b/target/arm/cpu-param.h
> index 68ffb12427..ef62371d8f 100644
> --- a/target/arm/cpu-param.h
> +++ b/target/arm/cpu-param.h
> @@ -34,4 +34,6 @@
>   
>   #define NB_MMU_MODES 15
>   
> +#define TARGET_TB_PCREL 1

Oh, this was meant to be system-mode only, as there is no virtual aliasing in user-only. 
But during development it was handy to test the feature in user-only.  And we might find 
that maintaining both mechanisms is more effort than not.


r~