qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 01/18] block: Make blk_{pread,pwrite}() return 0 on succes


From: Hanna Reitz
Subject: Re: [PATCH v2 01/18] block: Make blk_{pread,pwrite}() return 0 on success
Date: Wed, 6 Jul 2022 10:37:14 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0

On 05.07.22 18:15, Alberto Faria wrote:
They currently return the value of their 'bytes' parameter on success.

Make them return 0 instead, for consistency with other I/O functions and
in preparation to implement them using generated_co_wrapper. This also
makes it clear that short reads/writes are not possible.

Signed-off-by: Alberto Faria <afaria@redhat.com>
---
  block.c                          |  8 +++++---
  block/block-backend.c            |  7 ++-----
  block/qcow.c                     |  6 +++---
  hw/block/m25p80.c                |  2 +-
  hw/misc/mac_via.c                |  4 ++--
  hw/misc/sifive_u_otp.c           |  2 +-
  hw/nvram/eeprom_at24c.c          |  8 ++++----
  hw/nvram/spapr_nvram.c           | 14 +++++++-------
  hw/ppc/pnv_pnor.c                |  2 +-
  qemu-img.c                       | 25 +++++++++----------------
  qemu-io-cmds.c                   | 18 ++++++++++++------
  tests/unit/test-block-iothread.c |  4 ++--
  12 files changed, 49 insertions(+), 51 deletions(-)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]