[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 11/18] block: Add blk_co_pwrite_compressed()
From: |
Alberto Faria |
Subject: |
[PATCH v2 11/18] block: Add blk_co_pwrite_compressed() |
Date: |
Tue, 5 Jul 2022 17:15:19 +0100 |
Also convert blk_pwrite_compressed() into a generated_co_wrapper.
Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
---
block/block-backend.c | 8 ++++----
include/sysemu/block-backend-io.h | 7 +++++--
tests/unit/test-block-iothread.c | 18 ++++++++++++++++++
3 files changed, 27 insertions(+), 6 deletions(-)
diff --git a/block/block-backend.c b/block/block-backend.c
index ddb1d4e179..cc85558813 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -2324,13 +2324,13 @@ int coroutine_fn blk_co_pwrite_zeroes(BlockBackend
*blk, int64_t offset,
flags | BDRV_REQ_ZERO_WRITE);
}
-int blk_pwrite_compressed(BlockBackend *blk, int64_t offset, int64_t bytes,
- const void *buf)
+int coroutine_fn blk_co_pwrite_compressed(BlockBackend *blk, int64_t offset,
+ int64_t bytes, const void *buf)
{
QEMUIOVector qiov = QEMU_IOVEC_INIT_BUF(qiov, buf, bytes);
IO_OR_GS_CODE();
- return blk_pwritev_part(blk, offset, bytes, &qiov, 0,
- BDRV_REQ_WRITE_COMPRESSED);
+ return blk_co_pwritev_part(blk, offset, bytes, &qiov, 0,
+ BDRV_REQ_WRITE_COMPRESSED);
}
int blk_truncate(BlockBackend *blk, int64_t offset, bool exact,
diff --git a/include/sysemu/block-backend-io.h
b/include/sysemu/block-backend-io.h
index c64207cdcb..d129e2bed3 100644
--- a/include/sysemu/block-backend-io.h
+++ b/include/sysemu/block-backend-io.h
@@ -168,8 +168,11 @@ int blk_flush(BlockBackend *blk);
int blk_ioctl(BlockBackend *blk, unsigned long int req, void *buf);
-int blk_pwrite_compressed(BlockBackend *blk, int64_t offset, int64_t bytes,
- const void *buf);
+int generated_co_wrapper blk_pwrite_compressed(BlockBackend *blk,
+ int64_t offset, int64_t bytes,
+ const void *buf);
+int coroutine_fn blk_co_pwrite_compressed(BlockBackend *blk, int64_t offset,
+ int64_t bytes, const void *buf);
int blk_pdiscard(BlockBackend *blk, int64_t offset, int64_t bytes);
int blk_pwrite_zeroes(BlockBackend *blk, int64_t offset,
int64_t bytes, BdrvRequestFlags flags);
diff --git a/tests/unit/test-block-iothread.c b/tests/unit/test-block-iothread.c
index 274e9e3653..3a46886784 100644
--- a/tests/unit/test-block-iothread.c
+++ b/tests/unit/test-block-iothread.c
@@ -198,6 +198,20 @@ static void test_sync_op_blk_pwritev_part(BlockBackend
*blk)
g_assert_cmpint(ret, ==, -EIO);
}
+static void test_sync_op_blk_pwrite_compressed(BlockBackend *blk)
+{
+ uint8_t buf[512] = { 0 };
+ int ret;
+
+ /* Late error: Not supported */
+ ret = blk_pwrite_compressed(blk, 0, sizeof(buf), buf);
+ g_assert_cmpint(ret, ==, -ENOTSUP);
+
+ /* Early error: Negative offset */
+ ret = blk_pwrite_compressed(blk, -2, sizeof(buf), buf);
+ g_assert_cmpint(ret, ==, -EIO);
+}
+
static void test_sync_op_load_vmstate(BdrvChild *c)
{
uint8_t buf[512];
@@ -377,6 +391,10 @@ const SyncOpTest sync_op_tests[] = {
.name = "/sync-op/pwritev_part",
.fn = NULL,
.blkfn = test_sync_op_blk_pwritev_part,
+ }, {
+ .name = "/sync-op/pwrite_compressed",
+ .fn = NULL,
+ .blkfn = test_sync_op_blk_pwrite_compressed,
}, {
.name = "/sync-op/load_vmstate",
.fn = test_sync_op_load_vmstate,
--
2.36.1
- [PATCH v2 01/18] block: Make blk_{pread, pwrite}() return 0 on success, (continued)
- [PATCH v2 01/18] block: Make blk_{pread, pwrite}() return 0 on success, Alberto Faria, 2022/07/05
- [PATCH v2 02/18] block: Add a 'flags' param to blk_pread(), Alberto Faria, 2022/07/05
- [PATCH v2 03/18] block: Change blk_{pread,pwrite}() param order, Alberto Faria, 2022/07/05
- [PATCH v2 04/18] block: Make 'bytes' param of blk_{pread, pwrite}() an int64_t, Alberto Faria, 2022/07/05
- [PATCH v2 05/18] block: Make blk_co_pwrite() take a const buffer, Alberto Faria, 2022/07/05
- [PATCH v2 06/18] block: Implement blk_{pread, pwrite}() using generated_co_wrapper, Alberto Faria, 2022/07/05
- [PATCH v2 07/18] block: Add blk_{preadv,pwritev}(), Alberto Faria, 2022/07/05
- [PATCH v2 08/18] block: Add blk_[co_]preadv_part(), Alberto Faria, 2022/07/05
- [PATCH v2 09/18] block: Export blk_pwritev_part() in block-backend-io.h, Alberto Faria, 2022/07/05
- [PATCH v2 11/18] block: Add blk_co_pwrite_compressed(),
Alberto Faria <=
- [PATCH v2 10/18] block: Change blk_pwrite_compressed() param order, Alberto Faria, 2022/07/05
- [PATCH v2 12/18] block: Implement blk_pwrite_zeroes() using generated_co_wrapper, Alberto Faria, 2022/07/05
- [PATCH v2 13/18] block: Implement blk_pdiscard() using generated_co_wrapper, Alberto Faria, 2022/07/05
- [PATCH v2 14/18] block: Implement blk_flush() using generated_co_wrapper, Alberto Faria, 2022/07/05
- [PATCH v2 15/18] block: Add blk_co_ioctl(), Alberto Faria, 2022/07/05
- [PATCH v2 17/18] block: Reorganize some declarations in block-backend-io.h, Alberto Faria, 2022/07/05
- [PATCH v2 16/18] block: Add blk_co_truncate(), Alberto Faria, 2022/07/05
- [PATCH v2 18/18] block: Remove remaining unused symbols in coroutines.h, Alberto Faria, 2022/07/05
- Re: [PATCH v2 00/18] Make block-backend-io.h API more consistent, Hanna Reitz, 2022/07/06