[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 30/54] pckbd: move ps2_kbd_init() and ps2_mouse_init() to i804
From: |
Mark Cave-Ayland |
Subject: |
[PATCH v2 30/54] pckbd: move ps2_kbd_init() and ps2_mouse_init() to i8042_mmio_realize() |
Date: |
Fri, 24 Jun 2022 14:40:45 +0100 |
Move ps2_kbd_init() and ps2_mouse_init() from i8042_mm_init() to
i8042_mmio_realize() to further reduce the initialisation logic done in
i8042_mm_init().
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Acked-by: Helge Deller <deller@gmx.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/input/pckbd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c
index 1ab76793ea..72843f770e 100644
--- a/hw/input/pckbd.c
+++ b/hw/input/pckbd.c
@@ -685,6 +685,9 @@ static void i8042_mmio_realize(DeviceState *dev, Error
**errp)
/* Note we can't use dc->vmsd without breaking migration compatibility */
vmstate_register(NULL, 0, &vmstate_kbd, ks);
+
+ ks->kbd = ps2_kbd_init(kbd_update_kbd_irq, ks);
+ ks->mouse = ps2_mouse_init(kbd_update_aux_irq, ks);
}
static void i8042_mmio_init(Object *obj)
@@ -726,9 +729,6 @@ MMIOKBDState *i8042_mm_init(qemu_irq kbd_irq, qemu_irq
mouse_irq,
s->irq_kbd = kbd_irq;
s->irq_mouse = mouse_irq;
- s->kbd = ps2_kbd_init(kbd_update_kbd_irq, s);
- s->mouse = ps2_mouse_init(kbd_update_aux_irq, s);
-
return I8042_MMIO(dev);
}
--
2.30.2
- Re: [PATCH v2 22/54] pckbd: implement i8042_mmio_reset() for I8042_MMIO device, (continued)
- [PATCH v2 23/54] pckbd: add mask qdev property to I8042_MMIO device, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 24/54] pckbd: add size qdev property to I8042_MMIO device, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 25/54] pckbd: implement i8042_mmio_realize() function, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 26/54] pckbd: implement i8042_mmio_init() function, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 27/54] pckbd: alter i8042_mm_init() to return a I8042_MMIO device, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 28/54] pckbd: move mapping of I8042_MMIO registers to MIPS magnum machine, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 29/54] pckbd: more vmstate_register() from i8042_mm_init() to i8042_mmio_realize(), Mark Cave-Ayland, 2022/06/24
- [PATCH v2 30/54] pckbd: move ps2_kbd_init() and ps2_mouse_init() to i8042_mmio_realize(),
Mark Cave-Ayland <=
- [PATCH v2 31/54] ps2: make ps2_raise_irq() function static, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 32/54] ps2: use ps2_raise_irq() instead of calling update_irq() directly, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 33/54] ps2: introduce ps2_lower_irq() instead of calling update_irq() directly, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 34/54] ps2: add gpio for output IRQ and optionally use it in ps2_raise_irq() and ps2_lower_irq(), Mark Cave-Ayland, 2022/06/24
- [PATCH v2 35/54] pckbd: replace irq_kbd and irq_mouse with qemu_irq array in KBDState, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 38/54] lasips2: QOMify LASIPS2State, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 37/54] pl050: add QEMU interface comment, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 36/54] pl050: switch over from update_irq() function to PS2 device gpio, Mark Cave-Ayland, 2022/06/24