Re: [PATCH 06/14] aspeed: Add system-memory QOM link to SoC

[Peter Delevoryas]

> On Jun 23, 2022, at 5:30 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
> 
> On Thu, 23 Jun 2022 at 12:31, Peter Delevoryas <pdel@fb.com> wrote:
>> 
>> Right now it's just defined as the regular global system memory. If we
>> migrate all the SoC code to use this property instead of directly calling
>> get_system_memory(), then we can restrict the memory container for the SoC,
>> which will be useful for multi-SoC machines.
>> 
>> Signed-off-by: Peter Delevoryas <pdel@fb.com>
> 
>> static Property aspeed_soc_properties[] = {
>> +    DEFINE_PROP_LINK("system-memory", AspeedSoCState, system_memory,
>> +                     TYPE_MEMORY_REGION, MemoryRegion *),
> 
> To the extent that we have a convention, we tend to call this
> property on an SoC or CPU "memory", I think. (Better suggestions
> welcome...)

Oh oops, yes, in hindsight that is very obvious. I’ll change
this from “system-memory” to “memory”.

> 
> -- PMM