[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 09/23] target/arm: Rename helper_exception_with_syndrome
From: |
Richard Henderson |
Subject: |
[PATCH v3 09/23] target/arm: Rename helper_exception_with_syndrome |
Date: |
Thu, 9 Jun 2022 13:28:47 -0700 |
Rename to helper_exception_with_syndrome_el, to emphasize
that the target el is a parameter.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/helper.h | 2 +-
target/arm/translate.h | 6 +++---
target/arm/op_helper.c | 6 +++---
target/arm/translate.c | 6 +++---
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/target/arm/helper.h b/target/arm/helper.h
index 5161cdf73d..5a6802e3fa 100644
--- a/target/arm/helper.h
+++ b/target/arm/helper.h
@@ -45,7 +45,7 @@ DEF_HELPER_FLAGS_2(usad8, TCG_CALL_NO_RWG_SE, i32, i32, i32)
DEF_HELPER_FLAGS_3(sel_flags, TCG_CALL_NO_RWG_SE,
i32, i32, i32, i32)
DEF_HELPER_2(exception_internal, noreturn, env, i32)
-DEF_HELPER_4(exception_with_syndrome, noreturn, env, i32, i32, i32)
+DEF_HELPER_4(exception_with_syndrome_el, noreturn, env, i32, i32, i32)
DEF_HELPER_2(exception_bkpt_insn, noreturn, env, i32)
DEF_HELPER_2(exception_pc_alignment, noreturn, env, tl)
DEF_HELPER_1(setend, void, env)
diff --git a/target/arm/translate.h b/target/arm/translate.h
index f473a21ed4..c57830126b 100644
--- a/target/arm/translate.h
+++ b/target/arm/translate.h
@@ -332,9 +332,9 @@ static inline void gen_ss_advance(DisasContext *s)
static inline void gen_exception(int excp, uint32_t syndrome,
uint32_t target_el)
{
- gen_helper_exception_with_syndrome(cpu_env, tcg_constant_i32(excp),
- tcg_constant_i32(syndrome),
- tcg_constant_i32(target_el));
+ gen_helper_exception_with_syndrome_el(cpu_env, tcg_constant_i32(excp),
+ tcg_constant_i32(syndrome),
+ tcg_constant_i32(target_el));
}
/* Generate an architectural singlestep exception */
diff --git a/target/arm/op_helper.c b/target/arm/op_helper.c
index 2a8bdc2cbf..8a6a3b8551 100644
--- a/target/arm/op_helper.c
+++ b/target/arm/op_helper.c
@@ -381,7 +381,7 @@ void HELPER(yield)(CPUARMState *env)
* those EXCP values which are special cases for QEMU to interrupt
* execution and not to be used for exceptions which are passed to
* the guest (those must all have syndrome information and thus should
- * use exception_with_syndrome).
+ * use exception_with_syndrome*).
*/
void HELPER(exception_internal)(CPUARMState *env, uint32_t excp)
{
@@ -393,8 +393,8 @@ void HELPER(exception_internal)(CPUARMState *env, uint32_t
excp)
}
/* Raise an exception with the specified syndrome register value */
-void HELPER(exception_with_syndrome)(CPUARMState *env, uint32_t excp,
- uint32_t syndrome, uint32_t target_el)
+void HELPER(exception_with_syndrome_el)(CPUARMState *env, uint32_t excp,
+ uint32_t syndrome, uint32_t target_el)
{
raise_exception(env, excp, syndrome, target_el);
}
diff --git a/target/arm/translate.c b/target/arm/translate.c
index 87a899d638..dc033600c0 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -1119,9 +1119,9 @@ static void gen_exception_el(DisasContext *s, int excp,
uint32_t syn,
{
gen_set_condexec(s);
gen_set_pc_im(s, s->pc_curr);
- gen_helper_exception_with_syndrome(cpu_env,
- tcg_constant_i32(excp),
- tcg_constant_i32(syn), tcg_el);
+ gen_helper_exception_with_syndrome_el(cpu_env,
+ tcg_constant_i32(excp),
+ tcg_constant_i32(syn), tcg_el);
s->base.is_jmp = DISAS_NORETURN;
}
--
2.34.1
- [PATCH v3 00/23] target/arm: tidy exception routing, Richard Henderson, 2022/06/09
- [PATCH v3 01/23] target/arm: Mark exception helpers as noreturn, Richard Henderson, 2022/06/09
- [PATCH v3 02/23] target/arm: Add coproc parameter to syn_fp_access_trap, Richard Henderson, 2022/06/09
- [PATCH v3 04/23] target/arm: Move arm_singlestep_active out of line, Richard Henderson, 2022/06/09
- [PATCH v3 03/23] target/arm: Move exception_target_el out of line, Richard Henderson, 2022/06/09
- [PATCH v3 06/23] target/arm: Use is_a64 in arm_generate_debug_exceptions, Richard Henderson, 2022/06/09
- [PATCH v3 08/23] target/arm: Move arm_debug_exception_fsr to debug_helper.c, Richard Henderson, 2022/06/09
- [PATCH v3 09/23] target/arm: Rename helper_exception_with_syndrome,
Richard Henderson <=
- [PATCH v3 07/23] target/arm: Move exception_bkpt_insn to debug_helper.c, Richard Henderson, 2022/06/09
- [PATCH v3 10/23] target/arm: Introduce gen_exception_insn_el_v, Richard Henderson, 2022/06/09
- [PATCH v3 11/23] target/arm: Rename gen_exception_insn to gen_exception_insn_el, Richard Henderson, 2022/06/09
- [PATCH v3 12/23] target/arm: Introduce gen_exception_insn, Richard Henderson, 2022/06/09
- [PATCH v3 13/23] target/arm: Create helper_exception_swstep, Richard Henderson, 2022/06/09
- [PATCH v3 17/23] target/arm: Introduce gen_exception, Richard Henderson, 2022/06/09
- [PATCH v3 16/23] target/arm: Rename gen_exception to gen_exception_el, Richard Henderson, 2022/06/09
- [PATCH v3 05/23] target/arm: Move arm_generate_debug_exceptions out of line, Richard Henderson, 2022/06/09
- [PATCH v3 18/23] target/arm: Introduce gen_exception_el_v, Richard Henderson, 2022/06/09
- [PATCH v3 15/23] target/arm: Move gen_exception to translate.c, Richard Henderson, 2022/06/09