[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 03/23] target/arm: Move exception_target_el out of line
From: |
Richard Henderson |
Subject: |
[PATCH v3 03/23] target/arm: Move exception_target_el out of line |
Date: |
Thu, 9 Jun 2022 13:28:41 -0700 |
Move the function to op_helper.c, near raise_exception.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/internals.h | 16 +---------------
target/arm/op_helper.c | 15 +++++++++++++++
2 files changed, 16 insertions(+), 15 deletions(-)
diff --git a/target/arm/internals.h b/target/arm/internals.h
index a1bae4588a..af9de2dbe5 100644
--- a/target/arm/internals.h
+++ b/target/arm/internals.h
@@ -1098,21 +1098,6 @@ ARMVAParameters aa64_va_parameters(CPUARMState *env,
uint64_t va,
int aa64_va_parameter_tbi(uint64_t tcr, ARMMMUIdx mmu_idx);
int aa64_va_parameter_tbid(uint64_t tcr, ARMMMUIdx mmu_idx);
-static inline int exception_target_el(CPUARMState *env)
-{
- int target_el = MAX(1, arm_current_el(env));
-
- /*
- * No such thing as secure EL1 if EL3 is aarch32,
- * so update the target EL to EL3 in this case.
- */
- if (arm_is_secure(env) && !arm_el_is_aa64(env, 3) && target_el == 1) {
- target_el = 3;
- }
-
- return target_el;
-}
-
/* Determine if allocation tags are available. */
static inline bool allocation_tag_access_enabled(CPUARMState *env, int el,
uint64_t sctlr)
@@ -1339,6 +1324,7 @@ void define_cortex_a72_a57_a53_cp_reginfo(ARMCPU *cpu);
bool el_is_in_host(CPUARMState *env, int el);
void aa32_max_features(ARMCPU *cpu);
+int exception_target_el(CPUARMState *env);
/* Powers of 2 for sve_vq_map et al. */
#define SVE_VQ_POW2_MAP \
diff --git a/target/arm/op_helper.c b/target/arm/op_helper.c
index c4bd668870..97c8c9ec77 100644
--- a/target/arm/op_helper.c
+++ b/target/arm/op_helper.c
@@ -28,6 +28,21 @@
#define SIGNBIT (uint32_t)0x80000000
#define SIGNBIT64 ((uint64_t)1 << 63)
+int exception_target_el(CPUARMState *env)
+{
+ int target_el = MAX(1, arm_current_el(env));
+
+ /*
+ * No such thing as secure EL1 if EL3 is aarch32,
+ * so update the target EL to EL3 in this case.
+ */
+ if (arm_is_secure(env) && !arm_el_is_aa64(env, 3) && target_el == 1) {
+ target_el = 3;
+ }
+
+ return target_el;
+}
+
void raise_exception(CPUARMState *env, uint32_t excp,
uint32_t syndrome, uint32_t target_el)
{
--
2.34.1
- [PATCH v3 00/23] target/arm: tidy exception routing, Richard Henderson, 2022/06/09
- [PATCH v3 01/23] target/arm: Mark exception helpers as noreturn, Richard Henderson, 2022/06/09
- [PATCH v3 02/23] target/arm: Add coproc parameter to syn_fp_access_trap, Richard Henderson, 2022/06/09
- [PATCH v3 04/23] target/arm: Move arm_singlestep_active out of line, Richard Henderson, 2022/06/09
- [PATCH v3 03/23] target/arm: Move exception_target_el out of line,
Richard Henderson <=
- [PATCH v3 06/23] target/arm: Use is_a64 in arm_generate_debug_exceptions, Richard Henderson, 2022/06/09
- [PATCH v3 08/23] target/arm: Move arm_debug_exception_fsr to debug_helper.c, Richard Henderson, 2022/06/09
- [PATCH v3 09/23] target/arm: Rename helper_exception_with_syndrome, Richard Henderson, 2022/06/09
- [PATCH v3 07/23] target/arm: Move exception_bkpt_insn to debug_helper.c, Richard Henderson, 2022/06/09
- [PATCH v3 10/23] target/arm: Introduce gen_exception_insn_el_v, Richard Henderson, 2022/06/09
- [PATCH v3 11/23] target/arm: Rename gen_exception_insn to gen_exception_insn_el, Richard Henderson, 2022/06/09
- [PATCH v3 12/23] target/arm: Introduce gen_exception_insn, Richard Henderson, 2022/06/09
- [PATCH v3 13/23] target/arm: Create helper_exception_swstep, Richard Henderson, 2022/06/09
- [PATCH v3 17/23] target/arm: Introduce gen_exception, Richard Henderson, 2022/06/09
- [PATCH v3 16/23] target/arm: Rename gen_exception to gen_exception_el, Richard Henderson, 2022/06/09