Re: [PATCH 28/71] target/arm: Add PSTATE.{SM,ZA} to TB flags

[Richard Henderson]

On 6/6/22 08:58, Peter Maydell wrote:
> > +        if (FIELD_EX64(env->svcr, SVCR, SM)) {
> > +            DP_TBFLAG_A64(flags, PSTATE_SM, 1);
> > +        }
> > +        DP_TBFLAG_A64(flags, PSTATE_ZA, FIELD_EX64(env->svcr, SVCR, ZA));
>
> Why did you write these two differently? Don't they do the same
> thing (set the tb flag to the value of the bit in env->svcr) ?

A later patch adds to the IF.

r~

> Otherwise
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> thanks
> -- PMM