[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 22/71] target/arm: Add SMEEXC_EL to TB flags
From: |
Peter Maydell |
Subject: |
Re: [PATCH 22/71] target/arm: Add SMEEXC_EL to TB flags |
Date: |
Mon, 6 Jun 2022 14:25:18 +0100 |
On Thu, 2 Jun 2022 at 23:15, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> This is CheckSMEAccess, which is the basis for a set of
> related tests for various SME cpregs and instructions.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> + /* CPTR_EL3. Since EZ is negative we must check for EL3. */
Cut-n-paste error, should say "ESM" not "EZ" ?
> + if (arm_feature(env, ARM_FEATURE_EL3)
> + && !FIELD_EX64(env->cp15.cptr_el[3], CPTR_EL3, ESM)) {
> + return 3;
> + }
> +#endif
> + return 0;
> +}
Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH 12/71] target/arm: Rename sve_zcr_len_for_el to sve_vqm1_for_el, (continued)
- [PATCH 12/71] target/arm: Rename sve_zcr_len_for_el to sve_vqm1_for_el, Richard Henderson, 2022/06/02
- [PATCH 11/71] target/arm: Use uint32_t instead of bitmap for sve vq's, Richard Henderson, 2022/06/02
- [PATCH 13/71] target/arm: Split out load/store primitives to sve_ldst_internal.h, Richard Henderson, 2022/06/02
- [PATCH 15/71] target/arm: Move expand_pred_b to vec_internal.h, Richard Henderson, 2022/06/02
- [PATCH 16/71] target/arm: Use expand_pred_b in mve_helper.c, Richard Henderson, 2022/06/02
- [PATCH 17/71] target/arm: Move expand_pred_h to vec_internal.h, Richard Henderson, 2022/06/02
- [PATCH 20/71] target/arm: Add ID_AA64SMFR0_EL1, Richard Henderson, 2022/06/02
- [PATCH 22/71] target/arm: Add SMEEXC_EL to TB flags, Richard Henderson, 2022/06/02
- Re: [PATCH 22/71] target/arm: Add SMEEXC_EL to TB flags,
Peter Maydell <=
- [PATCH 28/71] target/arm: Add PSTATE.{SM,ZA} to TB flags, Richard Henderson, 2022/06/02
- [PATCH 18/71] target/arm: Export bfdotadd from vec_helper.c, Richard Henderson, 2022/06/02
- [PATCH 19/71] target/arm: Add isar_feature_aa64_sme, Richard Henderson, 2022/06/02
- [PATCH 14/71] target/arm: Export sve contiguous ldst support functions, Richard Henderson, 2022/06/02
- [PATCH 21/71] target/arm: Implement TPIDR2_EL0, Richard Henderson, 2022/06/02