Re: [PATCH v1 1/9] aspeed/adc: Add AST1030 support

[Cédric Le Goater]

On 3/22/22 03:51, Jamin Lin wrote:
> From: Steven Lee <steven_lee@aspeedtech.com>
>
> Per ast1030_v7.pdf, AST1030 ADC engine is identical to AST2600's ADC.
>
> Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> Signed-off-by: Steven Lee <steven_lee@aspeedtech.com>

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.



> ---
>   hw/adc/aspeed_adc.c         | 16 ++++++++++++++++
>   include/hw/adc/aspeed_adc.h |  1 +
>   2 files changed, 17 insertions(+)
>
> diff --git a/hw/adc/aspeed_adc.c b/hw/adc/aspeed_adc.c
> index c5fcae29f6..0d29663129 100644
> --- a/hw/adc/aspeed_adc.c
> +++ b/hw/adc/aspeed_adc.c
> @@ -389,6 +389,15 @@ static void aspeed_2600_adc_class_init(ObjectClass *klass, 
> void *data)
>       aac->nr_engines = 2;
>   }
>   
> +static void aspeed_1030_adc_class_init(ObjectClass *klass, void *data)
> +{
> +    DeviceClass *dc = DEVICE_CLASS(klass);
> +    AspeedADCClass *aac = ASPEED_ADC_CLASS(klass);
> +
> +    dc->desc = "ASPEED 1030 ADC Controller";
> +    aac->nr_engines = 2;
> +}
> +
>   static const TypeInfo aspeed_adc_info = {
>       .name = TYPE_ASPEED_ADC,
>       .parent = TYPE_SYS_BUS_DEVICE,
> @@ -415,6 +424,12 @@ static const TypeInfo aspeed_2600_adc_info = {
>       .class_init = aspeed_2600_adc_class_init,
>   };
>   
> +static const TypeInfo aspeed_1030_adc_info = {
> +    .name = TYPE_ASPEED_1030_ADC,
> +    .parent = TYPE_ASPEED_ADC,
> +    .class_init = aspeed_1030_adc_class_init, /* No change since AST2600 */
> +};
> +
>   static void aspeed_adc_register_types(void)
>   {
>       type_register_static(&aspeed_adc_engine_info);
> @@ -422,6 +437,7 @@ static void aspeed_adc_register_types(void)
>       type_register_static(&aspeed_2400_adc_info);
>       type_register_static(&aspeed_2500_adc_info);
>       type_register_static(&aspeed_2600_adc_info);
> +    type_register_static(&aspeed_1030_adc_info);
>   }
>   
>   type_init(aspeed_adc_register_types);
> diff --git a/include/hw/adc/aspeed_adc.h b/include/hw/adc/aspeed_adc.h
> index 2f166e8be1..ff1d06ea91 100644
> --- a/include/hw/adc/aspeed_adc.h
> +++ b/include/hw/adc/aspeed_adc.h
> @@ -17,6 +17,7 @@
>   #define TYPE_ASPEED_2400_ADC TYPE_ASPEED_ADC "-ast2400"
>   #define TYPE_ASPEED_2500_ADC TYPE_ASPEED_ADC "-ast2500"
>   #define TYPE_ASPEED_2600_ADC TYPE_ASPEED_ADC "-ast2600"
> +#define TYPE_ASPEED_1030_ADC TYPE_ASPEED_ADC "-ast1030"
>   OBJECT_DECLARE_TYPE(AspeedADCState, AspeedADCClass, ASPEED_ADC)
>   
>   #define TYPE_ASPEED_ADC_ENGINE "aspeed.adc.engine"