[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/11] aspeed/smc: Remove 'num_cs' field
From: |
Cédric Le Goater |
Subject: |
[PULL 04/11] aspeed/smc: Remove 'num_cs' field |
Date: |
Tue, 8 Mar 2022 13:21:42 +0100 |
It is not used anymore.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20220307071856.1410731-4-clg@kaod.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
include/hw/ssi/aspeed_smc.h | 1 -
hw/arm/aspeed.c | 2 --
hw/arm/aspeed_ast2600.c | 2 --
hw/arm/aspeed_soc.c | 2 --
hw/ssi/aspeed_smc.c | 7 -------
5 files changed, 14 deletions(-)
diff --git a/include/hw/ssi/aspeed_smc.h b/include/hw/ssi/aspeed_smc.h
index cad73ddc13f2..4a9354e13c7f 100644
--- a/include/hw/ssi/aspeed_smc.h
+++ b/include/hw/ssi/aspeed_smc.h
@@ -57,7 +57,6 @@ struct AspeedSMCState {
qemu_irq irq;
- uint32_t num_cs;
qemu_irq *cs_lines;
bool inject_failure;
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 65588017659c..90504ee44408 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -343,8 +343,6 @@ static void aspeed_machine_init(MachineState *machine)
&error_abort);
object_property_set_int(OBJECT(&bmc->soc), "hw-strap2", amc->hw_strap2,
&error_abort);
- object_property_set_int(OBJECT(&bmc->soc), "num-cs", amc->num_cs,
- &error_abort);
object_property_set_link(OBJECT(&bmc->soc), "dram",
OBJECT(machine->ram), &error_abort);
if (machine->kernel_filename) {
diff --git a/hw/arm/aspeed_ast2600.c b/hw/arm/aspeed_ast2600.c
index 21cd3342c578..c1e15e37739c 100644
--- a/hw/arm/aspeed_ast2600.c
+++ b/hw/arm/aspeed_ast2600.c
@@ -163,7 +163,6 @@ static void aspeed_soc_ast2600_init(Object *obj)
snprintf(typename, sizeof(typename), "aspeed.fmc-%s", socname);
object_initialize_child(obj, "fmc", &s->fmc, typename);
- object_property_add_alias(obj, "num-cs", OBJECT(&s->fmc), "num-cs");
for (i = 0; i < sc->spis_num; i++) {
snprintf(typename, sizeof(typename), "aspeed.spi%d-%s", i + 1,
socname);
@@ -383,7 +382,6 @@ static void aspeed_soc_ast2600_realize(DeviceState *dev,
Error **errp)
for (i = 0; i < sc->spis_num; i++) {
object_property_set_link(OBJECT(&s->spi[i]), "dram",
OBJECT(s->dram_mr), &error_abort);
- object_property_set_int(OBJECT(&s->spi[i]), "num-cs", 1, &error_abort);
if (!sysbus_realize(SYS_BUS_DEVICE(&s->spi[i]), errp)) {
return;
}
diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c
index 7d53cf2f5133..58714cb2a01d 100644
--- a/hw/arm/aspeed_soc.c
+++ b/hw/arm/aspeed_soc.c
@@ -170,7 +170,6 @@ static void aspeed_soc_init(Object *obj)
snprintf(typename, sizeof(typename), "aspeed.fmc-%s", socname);
object_initialize_child(obj, "fmc", &s->fmc, typename);
- object_property_add_alias(obj, "num-cs", OBJECT(&s->fmc), "num-cs");
for (i = 0; i < sc->spis_num; i++) {
snprintf(typename, sizeof(typename), "aspeed.spi%d-%s", i + 1,
socname);
@@ -327,7 +326,6 @@ static void aspeed_soc_realize(DeviceState *dev, Error
**errp)
/* SPI */
for (i = 0; i < sc->spis_num; i++) {
- object_property_set_int(OBJECT(&s->spi[i]), "num-cs", 1, &error_abort);
if (!sysbus_realize(SYS_BUS_DEVICE(&s->spi[i]), errp)) {
return;
}
diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c
index a5d8bb717fc7..6859f061c8be 100644
--- a/hw/ssi/aspeed_smc.c
+++ b/hw/ssi/aspeed_smc.c
@@ -1127,12 +1127,6 @@ static void aspeed_smc_realize(DeviceState *dev, Error
**errp)
s->r_timings = asc->r_timings;
s->conf_enable_w0 = asc->conf_enable_w0;
- /* Enforce some real HW limits */
- if (s->num_cs > asc->max_peripherals) {
- aspeed_smc_error("num_cs cannot exceed: %d", asc->max_peripherals);
- s->num_cs = asc->max_peripherals;
- }
-
/* DMA irq. Keep it first for the initialization in the SoC */
sysbus_init_irq(sbd, &s->irq);
@@ -1211,7 +1205,6 @@ static const VMStateDescription vmstate_aspeed_smc = {
};
static Property aspeed_smc_properties[] = {
- DEFINE_PROP_UINT32("num-cs", AspeedSMCState, num_cs, 1),
DEFINE_PROP_BOOL("inject-failure", AspeedSMCState, inject_failure, false),
DEFINE_PROP_LINK("dram", AspeedSMCState, dram_mr,
TYPE_MEMORY_REGION, MemoryRegion *),
--
2.34.1
- [PULL 00/11] aspeed queue, Cédric Le Goater, 2022/03/08
- [PULL 04/11] aspeed/smc: Remove 'num_cs' field,
Cédric Le Goater <=
- [PULL 02/11] aspeed/smc: Use max number of CE instead of 'num_cs', Cédric Le Goater, 2022/03/08
- [PULL 11/11] hw: aspeed_gpio: Cleanup stray semicolon after switch, Cédric Le Goater, 2022/03/08
- [PULL 10/11] hw/arm/aspeed: add Bletchley machine type, Cédric Le Goater, 2022/03/08
- [PULL 09/11] hw/arm/aspeed: allow missing spi_model, Cédric Le Goater, 2022/03/08
- [PULL 03/11] aspeed: Rework aspeed_board_init_flashes() interface, Cédric Le Goater, 2022/03/08
- [PULL 01/11] aspeed: Fix a potential memory leak bug in write_boot_rom(), Cédric Le Goater, 2022/03/08
- [PULL 07/11] aspeed/smc: Fix error log, Cédric Le Goater, 2022/03/08
- [PULL 05/11] aspeed/smc: Rename 'max_peripherals' to 'cs_num_max', Cédric Le Goater, 2022/03/08
- [PULL 06/11] aspeed/smc: Let the SSI core layer define the bus name, Cédric Le Goater, 2022/03/08
- [PULL 08/11] hw/block: m25p80: Add support for w25q01jvq, Cédric Le Goater, 2022/03/08