[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/6] hw/misc: Add a model of the Xilinx ZynqMP CRF
From: |
Edgar E. Iglesias |
Subject: |
Re: [PATCH v2 3/6] hw/misc: Add a model of the Xilinx ZynqMP CRF |
Date: |
Fri, 18 Feb 2022 23:00:16 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Fri, Feb 18, 2022 at 01:37:51PM +0000, Peter Maydell wrote:
> On Thu, 3 Feb 2022 at 14:01, Edgar E. Iglesias <edgar.iglesias@gmail.com>
> wrote:
> >
> > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> >
> > Add a model of the Xilinx ZynqMP CRF. At the moment this
> > is mostly a stub model.
> >
> > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> > ---
>
>
> > +#define TYPE_XLNX_ZYNQMP_CRF "xlnx.zynqmp_crf"
> > +
> > +#define XILINX_CRF(obj) \
> > + OBJECT_CHECK(XlnxZynqMPCRF, (obj), TYPE_XLNX_ZYNQMP_CRF)
>
> We prefer the OBJECT_DECLARE_SIMPLE_TYPE rather than directly
> defining a cast macro these days. (It also provides a typedef
> for you, among other things.)
>
> Apart from that, and dropping minimum_version_id_old,
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
Thanks Peter and Luc for review comments.
Sorry, things have been very busy around here, I'll try to get a new version
posted next week addressing all comments I've seen so far.
Best regards,
Edgar
- [PATCH v2 0/6] hw/arm: zynqmp: Add CRF and APU control to support PSCI, Edgar E. Iglesias, 2022/02/03
- [PATCH v2 1/6] hw/arm/xlnx-zynqmp: Add an unimplemented SERDES area, Edgar E. Iglesias, 2022/02/03
- [PATCH v2 4/6] hw/arm/xlnx-zynqmp: Connect the ZynqMP CRF, Edgar E. Iglesias, 2022/02/03
- [PATCH v2 2/6] target/arm: Make rvbar settable after realize, Edgar E. Iglesias, 2022/02/03
- [PATCH v2 3/6] hw/misc: Add a model of the Xilinx ZynqMP CRF, Edgar E. Iglesias, 2022/02/03
- [PATCH v2 5/6] hw/misc: Add a model of the Xilinx ZynqMP APU Control, Edgar E. Iglesias, 2022/02/03
- [PATCH v2 6/6] hw/arm/xlnx-zynqmp: Connect the ZynqMP APU Control, Edgar E. Iglesias, 2022/02/03