Re: [PATCH v2 3/6] hw/misc: Add a model of the Xilinx ZynqMP CRF

[Peter Maydell]

On Thu, 3 Feb 2022 at 14:01, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote:
>
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> Add a model of the Xilinx ZynqMP CRF. At the moment this
> is mostly a stub model.

> +static const VMStateDescription vmstate_crf = {
> +    .name = TYPE_XLNX_ZYNQMP_CRF,
> +    .version_id = 1,
> +    .minimum_version_id = 1,
> +    .minimum_version_id_old = 1,

This is still on my to-review list to look at properly, but
this setting of .minimum_version_id_old is incorrect. The
field is only used if the VMStateDescription sets a non-NULL
load_state_old function, which this one does not.

We cleaned this up in commit 17e313406126, and I'm about
to send a patch which drops the fields entirely.

thanks
-- PMM