[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/3] hw: aspeed_gpio: Simplify 1.8V defines
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v2 2/3] hw: aspeed_gpio: Simplify 1.8V defines |
|
Date: |
Tue, 20 Jul 2021 00:05:35 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 7/13/21 8:58 AM, Joel Stanley wrote:
> There's no need to define the registers relative to the 0x800 offset
> where the controller is mapped, as the device is instantiated as it's
> own model at the correct memory address.
>
> Simplify the defines and remove the offset to save future confusion.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> hw/gpio/aspeed_gpio.c | 73 +++++++++++++++++++++----------------------
> 1 file changed, 36 insertions(+), 37 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>