Re: [PATCH 04/18] target/arm: Use asimd_imm_const for A64 decode

[Richard Henderson]

On 6/28/21 6:58 AM, Peter Maydell wrote:
> The A64 AdvSIMD modified-immediate grouping uses almost the same
> constant encoding that A32 Neon does; reuse asimd_imm_const() (to
> which we add the AArch64-specific case for cmode 15 op 1) instead of
> reimplementing it all.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
>   target/arm/translate.h     |  3 +-
>   target/arm/translate-a64.c | 86 ++++----------------------------------
>   target/arm/translate.c     | 17 +++++++-
>   3 files changed, 24 insertions(+), 82 deletions(-)

I'm a little surprised that the fp16 case didn't move as well, but either way,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~