Re: [PATCH 0/2] STM32VLDISCOVERY Machine Model

[Philippe Mathieu-Daudé]

On 6/14/21 6:05 PM, Peter Maydell wrote:
> On Tue, 8 Jun 2021 at 17:10, Alexandre Iooss <erdnaxe@crans.org> wrote:
>>
>> This patch series adds the STM32VLDISCOVERY Machine to QEMU
>>
>> Information on the board is available at:
>> https://www.st.com/en/evaluation-tools/stm32vldiscovery.html
>>
>> Alexandre Iooss (2):
>>   stm32f100: Add the stm32f100 SoC
>>   stm32vldiscovery: Add the STM32VLDISCOVERY Machine
>>
>>  MAINTAINERS                             |  12 ++
>>  default-configs/devices/arm-softmmu.mak |   1 +
>>  hw/arm/Kconfig                          |  10 ++
>>  hw/arm/meson.build                      |   2 +
>>  hw/arm/stm32f100_soc.c                  | 182 ++++++++++++++++++++++++
>>  hw/arm/stm32vldiscovery.c               |  66 +++++++++
>>  include/hw/arm/stm32f100_soc.h          |  58 ++++++++
>>  7 files changed, 331 insertions(+)
>>  create mode 100644 hw/arm/stm32f100_soc.c
>>  create mode 100644 hw/arm/stm32vldiscovery.c
>>  create mode 100644 include/hw/arm/stm32f100_soc.h
> 
> Looks generally OK to me, but cc'ing Alistair who wrote the
> STM32F405 model in case he wants to have a look at it.

The SoC in the STM32Fxxx family seems very similar.

Maybe OK for this one but next machines should consider reuse
components. Alexandre, if you plan to add more SoC, you might
want to look at how the abstract TYPE_ATMEGA_MCU handles multiples
MCU of the same family.

Regards,

Phil.