Re: [PATCH v16 78/99] target/arm: cpu-exceptions, cpu-exceptions-aa64: new modules

[Claudio Fontana]

On 6/10/21 11:01 AM, Peter Maydell wrote:
> On Thu, 10 Jun 2021 at 09:45, Claudio Fontana <cfontana@suse.de> wrote:
>>
>> On 6/5/21 10:50 PM, Richard Henderson wrote:
>>> I don't see the point in the excessive replication of header files, for 
>>> exactly
>>> one declaration.  This is not the first example.
>>>
>>> What's wrong with internal.h?
>>
>> Doesn't mean anything and leads to a mess of unrelated code.
> 
> It is all related: it is "things that the target/arm code needs,
> which are not needed by anything outside target/arm".
> 
>> I think we should be better at creating meaningful modules
> 
> target/arm is a meaningful grouping of code :-)
> 

Well, seems a bit too large a grouping to me,

and it seems like more effort could be put into recognizing opportunities to 
split things into self-contained units when they show up,
with more clearly defined and commented interfaces about inputs/outputs and 
initialization dependencies,

instead of cramming everything together. Of course there is a balance to be 
had, but my impression is that using exclusively things like internal.h
leads to people adding anything new just piling unrelated things on top, and 
missing opportunities for doing things in a more self-contained way.

Just my 2c of course.

Ciao,

C.