Re: [PATCH v16 78/99] target/arm: cpu-exceptions, cpu-exceptions-aa64: new modules

[Richard Henderson]

On 6/4/21 8:52 AM, Alex Bennée wrote:
> From: Claudio Fontana <cfontana@suse.de>
>
> after restricting AArch64-specific code to TARGET_AARCH64 builds,
> we can now extract the exception handling code from cpu-sysemu,
> and split its AArch64-specific part into its own module.
>
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   target/arm/cpu-exceptions-aa64.h |  28 ++
>   target/arm/cpu-exceptions-aa64.c | 276 +++++++++++++
>   target/arm/cpu-exceptions.c      | 445 ++++++++++++++++++++

Oh, splitting stuff out of cpu-sysemu.c is fine, but back to the single binary 
theory, do we gain anything with two files?

> diff --git a/target/arm/cpu-user.c b/target/arm/cpu-user.c
> index 6a1a1fa273..a8e6f28ec6 100644
> --- a/target/arm/cpu-user.c
> +++ b/target/arm/cpu-user.c
> @@ -12,6 +12,7 @@
>   #include "qapi/qapi-commands-machine-target.h"
>   #include "qapi/error.h"
>   #include "cpu.h"
> +#include "cpu-exceptions-aa64.h"

Please point to what requires this include.


r~