[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/6] hw/arm/npcm7xx: Add EHCI and OHCI controllers
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH 5/6] hw/arm/npcm7xx: Add EHCI and OHCI controllers |
Date: |
Tue, 13 Oct 2020 09:05:30 +0200 |
On Thu, Oct 08, 2020 at 04:21:53PM -0700, Havard Skinnemoen wrote:
> The NPCM730 and NPCM750 chips have a single USB host port shared between
> a USB 2.0 EHCI host controller and a USB 1.1 OHCI host controller. This
> adds support for both of them.
>
> Testing notes:
> * With -device usb-kbd, qemu will automatically insert a full-speed
> hub, and the keyboard becomes controlled by the OHCI controller.
> * With -device usb-kbd,bus=usb-bus.0,port=1, the keyboard is directly
> attached to the port without any hubs, and the device becomes
> controlled by the EHCI controller since it's high speed capable.
> * With -device usb-kbd,bus=usb-bus.0,port=1,usb_version=1, the
> keyboard is directly attached to the port, but it only advertises
> itself as full-speed capable, so it becomes controlled by the OHCI
> controller.
>
> In all cases, the keyboard device enumerates correctly.
Looks good. Goes through the arm queue I guess?
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
- [PATCH 0/6] Additional NPCM7xx features, devices and tests, Havard Skinnemoen, 2020/10/08
- [PATCH 1/6] tests/qtest: Add npcm7xx timer test, Havard Skinnemoen, 2020/10/08
- [PATCH 2/6] Move npcm7xx_timer_reached_zero call out of npcm7xx_timer_pause, Havard Skinnemoen, 2020/10/08
- [PATCH 4/6] hw/misc: Add npcm7xx random number generator, Havard Skinnemoen, 2020/10/08
- [PATCH 5/6] hw/arm/npcm7xx: Add EHCI and OHCI controllers, Havard Skinnemoen, 2020/10/08
- Re: [PATCH 5/6] hw/arm/npcm7xx: Add EHCI and OHCI controllers,
Gerd Hoffmann <=
- [PATCH 3/6] hw/timer: Adding watchdog for NPCM7XX Timer., Havard Skinnemoen, 2020/10/08
- [PATCH 6/6] hw/gpio: Add GPIO model for Nuvoton NPCM7xx, Havard Skinnemoen, 2020/10/08
- Re: [PATCH 0/6] Additional NPCM7xx features, devices and tests, Peter Maydell, 2020/10/20