[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/5] hw/pci-host/versatile: Add the PCI_BAR_COUNT definiti
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2 4/5] hw/pci-host/versatile: Add the PCI_BAR_COUNT definition |
Date: |
Mon, 12 Oct 2020 14:44:21 +0100 |
On Mon, 12 Oct 2020 at 14:20, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Note from Peter Maydell:
>
> The versatile/realview PCI controller has:
> * three PCI BARs which represent memory windows on the
> PCI bus which bus-master PCI devices can use to
> write back into the system address space
> - the device SMAPn registers allow the guest to configure
> the mapping from "a bus-master access to an address
> on the PCI bus wherever the guest mapped BAR n"
> to "a system address", and the smap[] array holds
> those register values
>
> Use self-explicit PCI_BAR_COUNT definition instead of a magic
> value, and rename some misnamed variables indexing the smap[]
> array from 'win' to 'bar'.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v2 0/5] hw: Replace some magic by definitions, Philippe Mathieu-Daudé, 2020/10/12
- [PATCH v2 1/5] hw: Replace magic value by PCI_NUM_PINS definition, Philippe Mathieu-Daudé, 2020/10/12
- [PATCH v2 2/5] hw/pci-host/pam: Use ARRAY_SIZE() instead of magic value, Philippe Mathieu-Daudé, 2020/10/12
- [PATCH v2 3/5] hw/pci-host/versatile: Add the MEMORY_WINDOW_COUNT definition, Philippe Mathieu-Daudé, 2020/10/12
- [PATCH v2 4/5] hw/pci-host/versatile: Add the PCI_BAR_COUNT definition, Philippe Mathieu-Daudé, 2020/10/12
- Re: [PATCH v2 4/5] hw/pci-host/versatile: Add the PCI_BAR_COUNT definition,
Peter Maydell <=
- [PATCH v2 5/5] tests/qtest: Replace magic value by NANOSECONDS_PER_SECOND definition, Philippe Mathieu-Daudé, 2020/10/12
- Re: [PATCH v2 0/5] hw: Replace some magic by definitions, Richard Henderson, 2020/10/13