[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 13/42] target/arm: Define arm_cpu_do_unaligned_access for
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v7 13/42] target/arm: Define arm_cpu_do_unaligned_access for user-only |
|
Date: |
Thu, 18 Jun 2020 14:31:35 +0100 |
On Wed, 3 Jun 2020 at 02:13, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> We need this to raise unaligned exceptions from user mode.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> v6: Use EXCP_UNALIGNED for user-only and update cpu_loop.c.
Could you update the comment in cpu.h, maybe something like:
#define EXCP_UNALIGNED 22 /* v7M UNALIGNED UsageFault; also linux-user */
and also update the string printed by arm_log_exception():
#ifdef CONFIG_USER_ONLY
[EXCP_UNALIGNED] = "linux-user unaligned access fault",
#else
[EXCP_UNALIGNED] = "v7M UNALIGNED UsageFault",
#endif
Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
[PATCH v7 12/42] target/arm: Implement the SUBP instruction, Richard Henderson, 2020/06/02
[PATCH v7 14/42] target/arm: Add helper_probe_access, Richard Henderson, 2020/06/02
[PATCH v7 16/42] target/arm: Implement the STGP instruction, Richard Henderson, 2020/06/02
[PATCH v7 15/42] target/arm: Implement LDG, STG, ST2G instructions, Richard Henderson, 2020/06/02