[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 5/7] arm/acpi: fix duplicated _UID of PCI interrupt link devic
From: |
Heyi Guo |
Subject: |
[PATCH v3 5/7] arm/acpi: fix duplicated _UID of PCI interrupt link devices |
Date: |
Tue, 4 Feb 2020 09:43:23 +0800 |
Using _UID of 0 for all PCI interrupt link devices absolutely violates
the spec. Simply increase one by one.
Signed-off-by: Heyi Guo <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
---
Cc: Peter Maydell <address@hidden>
Cc: "Michael S. Tsirkin" <address@hidden>
Cc: Igor Mammedov <address@hidden>
Cc: Shannon Zhao <address@hidden>
Cc: address@hidden
Cc: address@hidden
---
hw/arm/virt-acpi-build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 5d157a9dd5..f3e340b172 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -189,7 +189,7 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry
*memmap,
uint32_t irqs = irq + i;
Aml *dev_gsi = aml_device("GSI%d", i);
aml_append(dev_gsi, aml_name_decl("_HID", aml_string("PNP0C0F")));
- aml_append(dev_gsi, aml_name_decl("_UID", aml_int(0)));
+ aml_append(dev_gsi, aml_name_decl("_UID", aml_int(i)));
crs = aml_resource_template();
aml_append(crs,
aml_interrupt(AML_CONSUMER, AML_LEVEL, AML_ACTIVE_HIGH,
--
2.19.1
- [PATCH v3 0/7] Some cleanup in arm/virt/acpi, Heyi Guo, 2020/02/03
- [PATCH v3 6/7] arm/acpi: simplify the description of PCI _CRS, Heyi Guo, 2020/02/03
- [PATCH v3 4/7] arm/acpi: fix PCI _PRT definition, Heyi Guo, 2020/02/03
- [PATCH v3 1/7] bios-tables-test: prepare to change ARM virt ACPI DSDT, Heyi Guo, 2020/02/03
- [PATCH v3 5/7] arm/acpi: fix duplicated _UID of PCI interrupt link devices,
Heyi Guo <=
- [PATCH v3 3/7] arm/virt/acpi: remove _ADR from devices identified by _HID, Heyi Guo, 2020/02/03
- [PATCH v3 2/7] arm/virt/acpi: remove meaningless sub device "RP0" from PCI0, Heyi Guo, 2020/02/03
- [PATCH v3 7/7] virt/acpi: update golden masters for DSDT update, Heyi Guo, 2020/02/03
- Re: [PATCH v3 0/7] Some cleanup in arm/virt/acpi, Heyi Guo, 2020/02/09
- Re: [PATCH v3 0/7] Some cleanup in arm/virt/acpi, Peter Maydell, 2020/02/11