[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 6/7] arm/acpi: simplify the description of PCI _CRS
From: |
Heyi Guo |
Subject: |
[PATCH v3 6/7] arm/acpi: simplify the description of PCI _CRS |
Date: |
Tue, 4 Feb 2020 09:43:24 +0800 |
The original code defines a named object for the resource template but
then returns the resource template object itself; the resulted output
is like below:
Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings
{
Name (RBUF, ResourceTemplate ()
{
WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode,
0x0000, // Granularity
0x0000, // Range Minimum
0x00FF, // Range Maximum
0x0000, // Translation Offset
0x0100, // Length
,, )
......
})
Return (ResourceTemplate ()
{
WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode,
0x0000, // Granularity
0x0000, // Range Minimum
0x00FF, // Range Maximum
0x0000, // Translation Offset
0x0100, // Length
,, )
......
})
}
So the named object "RBUF" is actually useless. The more natural way
is to return RBUF instead, or simply drop RBUF definition.
Choose the latter one to simplify the code.
Signed-off-by: Heyi Guo <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
---
Cc: Peter Maydell <address@hidden>
Cc: "Michael S. Tsirkin" <address@hidden>
Cc: Igor Mammedov <address@hidden>
Cc: Shannon Zhao <address@hidden>
Cc: address@hidden
Cc: address@hidden
---
hw/arm/virt-acpi-build.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index f3e340b172..fb4b166f82 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -236,7 +236,6 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry
*memmap,
size_mmio_high));
}
- aml_append(method, aml_name_decl("RBUF", rbuf));
aml_append(method, aml_return(rbuf));
aml_append(dev, method);
--
2.19.1
- [PATCH v3 0/7] Some cleanup in arm/virt/acpi, Heyi Guo, 2020/02/03
- [PATCH v3 6/7] arm/acpi: simplify the description of PCI _CRS,
Heyi Guo <=
- [PATCH v3 4/7] arm/acpi: fix PCI _PRT definition, Heyi Guo, 2020/02/03
- [PATCH v3 1/7] bios-tables-test: prepare to change ARM virt ACPI DSDT, Heyi Guo, 2020/02/03
- [PATCH v3 5/7] arm/acpi: fix duplicated _UID of PCI interrupt link devices, Heyi Guo, 2020/02/03
- [PATCH v3 3/7] arm/virt/acpi: remove _ADR from devices identified by _HID, Heyi Guo, 2020/02/03
- [PATCH v3 2/7] arm/virt/acpi: remove meaningless sub device "RP0" from PCI0, Heyi Guo, 2020/02/03
- [PATCH v3 7/7] virt/acpi: update golden masters for DSDT update, Heyi Guo, 2020/02/03
- Re: [PATCH v3 0/7] Some cleanup in arm/virt/acpi, Heyi Guo, 2020/02/09
- Re: [PATCH v3 0/7] Some cleanup in arm/virt/acpi, Peter Maydell, 2020/02/11