[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v2 20/68] target/arm: Convert load/store (register
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-arm] [PATCH v2 20/68] target/arm: Convert load/store (register, immediate, literal) |
|
Date: |
Tue, 27 Aug 2019 13:27:25 +0100 |
On Fri, 23 Aug 2019 at 15:54, Peter Maydell <address@hidden> wrote:
>
> On Mon, 19 Aug 2019 at 22:38, Richard Henderson
> <address@hidden> wrote:
> >
> > Signed-off-by: Richard Henderson <address@hidden>
> > ---
> > target/arm/translate.c | 797 ++++++++++++++++++-----------------------
> > target/arm/a32.decode | 120 +++++++
> > target/arm/t32.decode | 141 ++++++++
> > 3 files changed, 615 insertions(+), 443 deletions(-)
>
> This one is brutal to review. I got through review of all the
> decode file patterns but got bogged down when I started looking
> at the .c file changes... I might come back to it alter.
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- Re: [Qemu-arm] [PATCH v2 21/68] target/arm: Convert Synchronization primitives, (continued)
[Qemu-arm] [PATCH v2 26/68] target/arm: Convert MOVW, MOVT, Richard Henderson, 2019/08/19
[Qemu-arm] [PATCH v2 20/68] target/arm: Convert load/store (register, immediate, literal), Richard Henderson, 2019/08/19
[Qemu-arm] [PATCH v2 23/68] target/arm: Convert Parallel addition and subtraction, Richard Henderson, 2019/08/19
[Qemu-arm] [PATCH v2 24/68] target/arm: Convert Packing, unpacking, saturation, and reversal, Richard Henderson, 2019/08/19
[Qemu-arm] [PATCH v2 27/68] target/arm: Convert LDM, STM, Richard Henderson, 2019/08/19
[Qemu-arm] [PATCH v2 30/68] target/arm: Diagnose base == pc for LDM/STM, Richard Henderson, 2019/08/19
[Qemu-arm] [PATCH v2 25/68] target/arm: Convert Signed multiply, signed and unsigned divide, Richard Henderson, 2019/08/19