[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v5 22/24] target/arm: Implement ARMv8.5-RNG
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-arm] [PATCH v5 22/24] target/arm: Implement ARMv8.5-RNG |
|
Date: |
Fri, 10 May 2019 09:21:52 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/10/19 9:20 AM, Peter Maydell wrote:
> On Fri, 10 May 2019 at 17:17, Richard Henderson
> <address@hidden> wrote:
>>
>> On 5/10/19 9:01 AM, Peter Maydell wrote:
>>> Don't these need to be marked ARM_CP_IO for the benefit
>>> of -icount ?
>>
>> I don't think so. There's no lock taken, as for mmio devices. It's not not
>> related to time, virtual or otherwise. There are no possible exceptions. I
>> can't think of anything that would make icount care.
>>
>> Have I missed something?
>
> If icount decides it needs to replay execution of the TB
> which the RNDR access is in, won't it get a different
> number back the second time it executes ?
Yes, it will. I forgot about replay.
r~