[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v2 6/8] hw: arm: Support both legacy and current R
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-arm] [PATCH v2 6/8] hw: arm: Support both legacy and current RSDP build |
Date: |
Fri, 30 Nov 2018 10:38:22 +0100 |
On Thu, 29 Nov 2018 14:24:26 +0100
Samuel Ortiz <address@hidden> wrote:
> We add the ability to build legacy or current RSDP tables, based on the
> AcpiRsdpData revision field passed to build_rsdp().
> Although arm/virt only uses RSDP v2, adding that capability to
> build_rsdp will allow us to share the RSDP build code between ARM and x86.
>
> Signed-off-by: Samuel Ortiz <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
> ---
> hw/arm/virt-acpi-build.c | 37 ++++++++++++++++++++++++++-----------
> 1 file changed, 26 insertions(+), 11 deletions(-)
>
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index 4782aea4fe..e1338b6f5a 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -378,23 +378,38 @@ build_rsdp(GArray *tbl, BIOSLinker *linker,
> AcpiRsdpData *rsdp_data)
> g_array_append_vals(tbl, rsdp_data->oem_id, 6); /* OEMID */
> build_append_int_noprefix(tbl, rsdp_data->revision, 1); /* Revision */
> build_append_int_noprefix(tbl, 0, 4); /* RsdtAddress */
> - build_append_int_noprefix(tbl, 36, 4); /* Length */
> -
> - /* XSDT address to be filled by guest linker */
> - build_append_int_noprefix(tbl, 0, 8); /* XsdtAddress */
> - bios_linker_loader_add_pointer(linker, ACPI_BUILD_RSDP_FILE,
> - 24, 8,
> - ACPI_BUILD_TABLE_FILE,
> - *rsdp_data->xsdt_tbl_offset);
> -
> - build_append_int_noprefix(tbl, 0, 1); /* Extended Checksum */
> - build_append_int_noprefix(tbl, 0, 3); /* Reserved */
> + if (rsdp_data->rsdt_tbl_offset) {
> + /* RSDT address to be filled by guest linker */
> + bios_linker_loader_add_pointer(linker,
> + ACPI_BUILD_RSDP_FILE, 16, 4,
> + ACPI_BUILD_TABLE_FILE,
> + *rsdp_data->rsdt_tbl_offset);
> + }
>
> /* Checksum to be filled by guest linker */
> bios_linker_loader_add_checksum(linker, ACPI_BUILD_RSDP_FILE,
> 0, 20, /* ACPI rev 1.0 RSDP size */
> 8);
>
> + if (rsdp_data->revision == 0) {
> + /* ACPI 1.0 RSDP, we're done */
> + return;
> + }
> +
> + /* The RSDP revision is 2 and later, we must have an XSDT pointer */
> + g_assert(rsdp_data->xsdt_tbl_offset != NULL);
> +
> + build_append_int_noprefix(tbl, 36, 4); /* Length */
> +
> + /* XSDT address to be filled by guest linker */
> + build_append_int_noprefix(tbl, 0, 8); /* XsdtAddress */
> + bios_linker_loader_add_pointer(linker, ACPI_BUILD_RSDP_FILE, 24, 8,
> + ACPI_BUILD_TABLE_FILE,
> + *rsdp_data->xsdt_tbl_offset);
> +
> + build_append_int_noprefix(tbl, 0, 1); /* Extended Checksum */
> + build_append_int_noprefix(tbl, 0, 3); /* Reserved */
> +
> /* Extended checksum to be filled by Guest linker */
> bios_linker_loader_add_checksum(linker, ACPI_BUILD_RSDP_FILE,
> 0, 36, /* ACPI rev 2.0 RSDP size */
- Re: [Qemu-arm] [Qemu-devel] [PATCH v2 4/8] hw: arm: Carry RSDP specific data through AcpiRsdpData, (continued)
- Re: [Qemu-arm] [PATCH v2 6/8] hw: arm: Support both legacy and current RSDP build,
Igor Mammedov <=
[Qemu-arm] [PATCH v2 7/8] hw: acpi: Export and share the ARM RSDP build, Samuel Ortiz, 2018/11/29
[Qemu-arm] [PATCH v2 8/8] hw: acpi: Remove AcpiRsdpDescriptor and fix tests, Samuel Ortiz, 2018/11/29
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 0/8] hw: acpi: RSDP fixes and refactoring, Igor Mammedov, 2018/11/30