[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [RFC v8 15/18] hw/arm/virt: Add virtio-iommu
From: |
Auger Eric |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [RFC v8 15/18] hw/arm/virt: Add virtio-iommu to the virt board |
Date: |
Wed, 14 Nov 2018 17:41:18 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
Hi Jean,
On 11/14/18 5:01 PM, Jean-Philippe Brucker wrote:
> On 09/11/2018 11:29, Eric Auger wrote:
>> +static void create_virtio_iommu(VirtMachineState *vms,
>> + const char *pciehb_nodename, PCIBus *bus)
>> +{
>> + const char compat[] = "virtio,pci-iommu";
>> + uint16_t bdf = 0x8; /* 00:01.0 */
>> + DeviceState *dev;
>> + char *node;
>> +
>> + dev = qdev_create(BUS(bus), TYPE_VIRTIO_IOMMU_PCI);
>> + object_property_set_bool(OBJECT(dev), true, "realized", &error_fatal);
>
> For the Arm virt platform, should msi_bypass default to false? Otherwise
> I don't think pass-through to guest userpace will work.
That's correct. It's a regression compared to v7. I will fix this soon
while doing the pc machine integration + resv regions flaws you reported
in the meantime.
Thanks!
Eric
>
> Thanks,
> Jean
>
- [Qemu-arm] [RFC v8 09/18] virtio-iommu: Implement translate, (continued)
- [Qemu-arm] [RFC v8 09/18] virtio-iommu: Implement translate, Eric Auger, 2018/11/09
- [Qemu-arm] [RFC v8 10/18] virtio-iommu: Implement probe request, Eric Auger, 2018/11/09
- [Qemu-arm] [RFC v8 11/18] virtio-iommu: Add an msi_bypass property, Eric Auger, 2018/11/09
- [Qemu-arm] [RFC v8 12/18] virtio-iommu: Implement fault reporting, Eric Auger, 2018/11/09
- [Qemu-arm] [RFC v8 13/18] virtio_iommu: Handle reserved regions in translation process, Eric Auger, 2018/11/09
- [Qemu-arm] [RFC v8 14/18] virtio-iommu-pci: Add virtio iommu pci support, Eric Auger, 2018/11/09
- [Qemu-arm] [RFC v8 15/18] hw/arm/virt: Add virtio-iommu to the virt board, Eric Auger, 2018/11/09
- Re: [Qemu-arm] [RFC v8 15/18] hw/arm/virt: Add virtio-iommu to the virt board, Bharat Bhushan, 2018/11/22
- [Qemu-arm] [RFC v8 16/18] hw/arm/virt-acpi-build: Introduce fill_iort_idmap helper, Eric Auger, 2018/11/09
- [Qemu-arm] [RFC v8 17/18] hw/arm/virt-acpi-build: Add virtio-iommu node in IORT table, Eric Auger, 2018/11/09
- [Qemu-arm] [RFC v8 18/18] hw/arm/virt: Allow virtio-iommu instantiation, Eric Auger, 2018/11/09