[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [RFC v8 11/18] virtio-iommu: Add an msi_bypass property
From: |
Jean-Philippe Brucker |
Subject: |
Re: [Qemu-arm] [RFC v8 11/18] virtio-iommu: Add an msi_bypass property |
Date: |
Wed, 14 Nov 2018 16:01:18 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 09/11/2018 11:29, Eric Auger wrote:
> +static void virtio_iommu_register_resv_region(viommu_endpoint *ep,
> + uint8_t subtype,
> + uint64_t start, uint64_t end)
> +{
> + viommu_interval *interval;
> + struct virtio_iommu_probe_resv_mem *reg;
> +
> + interval = g_malloc0(sizeof(*interval));
> + interval->low = start;
> + interval->high = end;
> +
> + reg = g_malloc0(sizeof(*reg));
> + reg->subtype = subtype;
> + reg->start = cpu_to_le64(start);
> + reg->end = cpu_to_le64(end);
> +
> + g_tree_insert(ep->reserved_regions, interval, reg);
> +}
> +
> static viommu_endpoint *virtio_iommu_get_endpoint(VirtIOIOMMU *s,
> uint32_t ep_id)
> {
> @@ -120,6 +142,12 @@ static viommu_endpoint
> *virtio_iommu_get_endpoint(VirtIOIOMMU *s,
> ep->reserved_regions = g_tree_new_full((GCompareDataFunc)interval_cmp,
> NULL, (GDestroyNotify)g_free,
> (GDestroyNotify)g_free);
> + if (s->msi_bypass) {
> + virtio_iommu_register_resv_region(ep, VIRTIO_IOMMU_RESV_MEM_T_MSI,
> + IOAPIC_RANGE_START,
> + IOAPIC_RANGE_SIZE);
The last argument of register_resv_region is 'end' but you're passing a size
Thanks,
Jean
- [Qemu-arm] [RFC v8 05/18] virtio-iommu: Add the iommu regions, (continued)
- [Qemu-arm] [RFC v8 05/18] virtio-iommu: Add the iommu regions, Eric Auger, 2018/11/09
- [Qemu-arm] [RFC v8 03/18] virtio-iommu: Add skeleton, Eric Auger, 2018/11/09
- [Qemu-arm] [RFC v8 07/18] virtio-iommu: Implement attach/detach command, Eric Auger, 2018/11/09
- [Qemu-arm] [RFC v8 04/18] virtio-iommu: Decode the command payload, Eric Auger, 2018/11/09
- [Qemu-arm] [RFC v8 08/18] virtio-iommu: Implement map/unmap, Eric Auger, 2018/11/09
- [Qemu-arm] [RFC v8 06/18] virtio-iommu: Endpoint and domains structs and helpers, Eric Auger, 2018/11/09
- [Qemu-arm] [RFC v8 09/18] virtio-iommu: Implement translate, Eric Auger, 2018/11/09
- [Qemu-arm] [RFC v8 10/18] virtio-iommu: Implement probe request, Eric Auger, 2018/11/09
- [Qemu-arm] [RFC v8 11/18] virtio-iommu: Add an msi_bypass property, Eric Auger, 2018/11/09
- Re: [Qemu-arm] [RFC v8 11/18] virtio-iommu: Add an msi_bypass property,
Jean-Philippe Brucker <=
- [Qemu-arm] [RFC v8 12/18] virtio-iommu: Implement fault reporting, Eric Auger, 2018/11/09
- [Qemu-arm] [RFC v8 13/18] virtio_iommu: Handle reserved regions in translation process, Eric Auger, 2018/11/09
- [Qemu-arm] [RFC v8 14/18] virtio-iommu-pci: Add virtio iommu pci support, Eric Auger, 2018/11/09
- [Qemu-arm] [RFC v8 15/18] hw/arm/virt: Add virtio-iommu to the virt board, Eric Auger, 2018/11/09
- Re: [Qemu-arm] [RFC v8 15/18] hw/arm/virt: Add virtio-iommu to the virt board, Bharat Bhushan, 2018/11/22
- [Qemu-arm] [RFC v8 16/18] hw/arm/virt-acpi-build: Introduce fill_iort_idmap helper, Eric Auger, 2018/11/09