[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v3 7/7] arm: fix aa64_generate_debug_exceptions to
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH v3 7/7] arm: fix aa64_generate_debug_exceptions to work with EL2 |
Date: |
Sun, 11 Nov 2018 14:47:20 +0000 |
On 9 November 2018 at 15:21, Alex Bennée <address@hidden> wrote:
> The test was incomplete and incorrectly caused debug exceptions to be
> generated when returning to EL2 after a failed attempt to single-step
> an EL1 instruction. Fix this while cleaning up the function a little.
> @@ -2833,9 +2845,6 @@ static inline bool
> aa32_generate_debug_exceptions(CPUARMState *env)
> * since the pseudocode has it at all callsites except for the one in
> * CheckSoftwareStep(), where it is elided because both branches would
> * always return the same value.
> - *
> - * Parts of the pseudocode relating to EL2 and EL3 are omitted because we
> - * don't yet implement those exception levels or their associated trap bits.
> */
In hindsight I regret not standardizing on a greppable tag for
marking these kinds of "we don't do X because we don't implement
feature Y" comments...
thanks
-- PMM
- [Qemu-arm] [PATCH v3 0/7] KVM Guest Debug fixes (plus TCG EL2 debug tweaks), Alex Bennée, 2018/11/09
- [Qemu-arm] [PATCH v3 7/7] arm: fix aa64_generate_debug_exceptions to work with EL2, Alex Bennée, 2018/11/09
- [Qemu-arm] [PATCH v3 2/7] target/arm64: hold BQL when calling do_interrupt(), Alex Bennée, 2018/11/09
- [Qemu-arm] [PATCH v3 1/7] target/arm64: properly handle DBGVR RESS bits, Alex Bennée, 2018/11/09
- [Qemu-arm] [PATCH v3 6/7] arm: use symbolic MDCR_TDE in arm_debug_target_el, Alex Bennée, 2018/11/09
- [Qemu-arm] [PATCH v3 3/7] target/arm64: kvm debug set target_el when passing exception to guest, Alex Bennée, 2018/11/09
- [Qemu-arm] [PATCH v3 5/7] tests/guest-debug: don't use symbol resolution for PC checks, Alex Bennée, 2018/11/09
- [Qemu-arm] [PATCH v3 4/7] tests/guest-debug: fix scoping of failcount, Alex Bennée, 2018/11/09
- Re: [Qemu-arm] [PATCH v3 0/7] KVM Guest Debug fixes (plus TCG EL2 debug tweaks), Alex Bennée, 2018/11/09
- Re: [Qemu-arm] [PATCH v3 0/7] KVM Guest Debug fixes (plus TCG EL2 debug tweaks), Peter Maydell, 2018/11/12