[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSD
From: |
Samuel Ortiz |
Subject: |
Re: [Qemu-arm] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP |
Date: |
Thu, 8 Nov 2018 15:36:11 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Hi Igor,
On Thu, Nov 08, 2018 at 03:16:23PM +0100, Igor Mammedov wrote:
> On Mon, 5 Nov 2018 02:40:28 +0100
> Samuel Ortiz <address@hidden> wrote:
>
> > XSDT is the 64-bit version of the legacy ACPI RSDT (Root System
> > Description Table). RSDT only allow for 32-bit addressses and have thus
> > been deprecated. Since ACPI version 2.0, RSDPs should point at XSDTs and
> > no longer RSDTs, although RSDTs are still supported for backward
> > compatibility.
> >
> > Since version 2.0, RSDPs should add an extended checksum, a complete table
> > length and a version field to the table.
>
> This patch re-implements what arm/virt board already does
> and fixes checksum bug in the later and at the same time
> without a user (within the patch).
>
> I'd suggest redo it a way similar to FADT refactoring
> patch 1: fix checksum bug in virt/arm
> patch 2: update reference tables in test
I now see what you meant with the ACPI reference tables, thanks.
I'll follow your advice.
Cheers,
Samuel.
- Re: [Qemu-arm] [PATCH v5 01/24] hw: i386: Decouple the ACPI build from the PC machine type, (continued)
[Qemu-arm] [PATCH v5 03/24] hw: acpi: The RSDP build API can return void, Samuel Ortiz, 2018/11/04
[Qemu-arm] [PATCH v5 04/24] hw: acpi: Export the RSDP build API, Samuel Ortiz, 2018/11/04
[Qemu-arm] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP, Samuel Ortiz, 2018/11/04
[Qemu-arm] [PATCH v5 06/24] hw: acpi: Factorize the RSDP build API implementation, Samuel Ortiz, 2018/11/04
[Qemu-arm] [PATCH v5 07/24] hw: acpi: Generalize AML build routines, Samuel Ortiz, 2018/11/04