[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v5 03/24] hw: acpi: The RSDP build API can return
|
From: |
Samuel Ortiz |
|
Subject: |
Re: [Qemu-arm] [PATCH v5 03/24] hw: acpi: The RSDP build API can return void |
|
Date: |
Tue, 6 Nov 2018 11:43:06 +0100 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Tue, Nov 06, 2018 at 11:23:39AM +0100, Paolo Bonzini wrote:
> On 05/11/2018 02:40, Samuel Ortiz wrote:
> > /* RSDP */
> > -static GArray *
> > +static void
> > build_rsdp(GArray *rsdp_table, BIOSLinker *linker, unsigned
> > xsdt_tbl_offset)
> > {
> > AcpiRsdpDescriptor *rsdp = acpi_data_push(rsdp_table, sizeof *rsdp);
> > @@ -392,8 +392,6 @@ build_rsdp(GArray *rsdp_table, BIOSLinker *linker,
> > unsigned xsdt_tbl_offset)
> > bios_linker_loader_add_checksum(linker, ACPI_BUILD_RSDP_FILE,
> > (char *)rsdp - rsdp_table->data, sizeof *rsdp,
> > (char *)&rsdp->checksum - rsdp_table->data);
> > -
> > - return rsdp_table;
> > }
> >
>
> Better than v4. :)
Right, I followed Philippe's advice and it does make things clearer :)
Cheers,
Samuel.