[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 05/10] hw/sd/sdhci.c: Update to use SDBus APIs
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-arm] [PATCH 05/10] hw/sd/sdhci.c: Update to use SDBus APIs |
|
Date: |
Sun, 20 Dec 2015 17:10:43 +0000 |
On 19 December 2015 at 21:39, Peter Crosthwaite
<address@hidden> wrote:
> On Fri, Dec 11, 2015 at 04:37:06PM +0000, Peter Maydell wrote:
>> + carddev = qdev_create(qdev_get_child_bus(dev, "sd-bus"), TYPE_SD);
>> + qdev_prop_set_drive(carddev, "drive", blk, errp);
>> + if (*errp) {
>
> It is generally valid for an errp to be NULL. I think we should use a
> local even if we know the caller will not pass NULL.
Agreed.
thanks
-- PMM
- Re: [Qemu-arm] [PATCH 03/10] hw/sd/sd.c: Convert sd_reset() function into Device reset method, (continued)
- [Qemu-arm] [PATCH 07/10] hw/sd/pxa2xx_mmci: convert to SysBusDevice object, Peter Maydell, 2015/12/11
- [Qemu-arm] [PATCH 09/10] hw/sd/pxa2xx_mmci: Convert to VMStateDescription, Peter Maydell, 2015/12/11
- [Qemu-arm] [PATCH 05/10] hw/sd/sdhci.c: Update to use SDBus APIs, Peter Maydell, 2015/12/11
- [Qemu-arm] [PATCH 10/10] hw/sd/pxa2xx_mmci: Add reset function, Peter Maydell, 2015/12/11
- Re: [Qemu-arm] [Qemu-devel] [PATCH 00/10] hw/sd: QOMify sd.c (and pxa2xx_mmci), Alistair Francis, 2015/12/16