[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] pkl: Fix leaking of exceptions inside try blocks
|
From: |
Mohammad-Reza Nabipoor |
|
Subject: |
Re: [PATCH 1/2] pkl: Fix leaking of exceptions inside try blocks |
|
Date: |
Mon, 27 Dec 2021 03:36:36 +0330 |
Hi, Jose.
On Sun, Dec 26, 2021 at 07:50:46PM +0100, Jose E. Marchesi wrote:
>
> > Hi Mohammad.
> >
> >> Without this patch the code generator leaves the exception(s) in
> >> exception stack for the following code:
> >>
> >> try return something;
> >> catch {}
> >>
> >> 2021-12-26 Mohammad-Reza Nabipoor <mnabipoor@gnu.org>
> >>
> >> * libpoke/pkl-ast.h (struct pkl_ast_return_stmt): Add new field
> >> `npopes` (number of `pope`s).
> >> (PKL_AST_RETURN_STMT_NPOPES): New macro.
> >> * libpoke/pkl-ast.c (pkl_ast_finish_returns_1): Add new arg `npopes`
> >> to count the `pope`s.
> >> (pkl_ast_finish_returns): Likewise.
> >> * libpoke/pkl-gen.c (pkl_gen_ps_return_stmt): Insert necessary `pope`
> >> instruction(s).
> >
> > Very nice catch (:P) and OK for master.
>
> Actually, it is probably good to install this in maint/poke-1 as well,
> in case we release a bugfix release.
>
Pushed to both master and maint/poke-1.
Thanks.